Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 10700099: NSS Channel ID: don't check ECC support on every socket creation. (Closed)

Created:
8 years, 5 months ago by mattm
Modified:
8 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

NSS Channel ID: don't check ECC support on every socket creation. Add static function to ECPrivateKey to get which NSS slot it uses. BUG=127506 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145777

Patch Set 1 : . #

Patch Set 2 : move/update the comment #

Total comments: 2

Patch Set 3 : move the magic into ECPrivateKey #

Total comments: 1

Patch Set 4 : remove the no longer needed forward declaration #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -10 lines) Patch
M crypto/ec_private_key.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M crypto/ec_private_key_nss.cc View 1 2 5 chunks +36 lines, -2 lines 0 comments Download
M crypto/ec_private_key_openssl.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 1 2 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mattm
8 years, 5 months ago (2012-07-04 01:17:36 UTC) #1
Ryan Sleevi
Matt, It definitely feels like the wrong layer to be pushing this all the way ...
8 years, 5 months ago (2012-07-04 01:36:33 UTC) #2
mattm
Redone to move the test into ECPrivateKey and have the client socket check that.
8 years, 5 months ago (2012-07-04 02:18:15 UTC) #3
Ryan Sleevi
lgtm
8 years, 5 months ago (2012-07-04 02:58:17 UTC) #4
Ryan Sleevi
http://codereview.chromium.org/10700099/diff/12/crypto/ec_private_key.h File crypto/ec_private_key.h (right): http://codereview.chromium.org/10700099/diff/12/crypto/ec_private_key.h#newcode25 crypto/ec_private_key.h:25: #endif Still needed?
8 years, 5 months ago (2012-07-04 03:00:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mattm@chromium.org/10700099/14005
8 years, 5 months ago (2012-07-09 21:39:13 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-07-09 23:12:15 UTC) #7
Change committed as 145777

Powered by Google App Engine
This is Rietveld 408576698