Prevent code folding in the ThreadWatcher ThreadUnresponsive_X functions.

chrome/browser/metrics/thread_watcher.cc

Index: chrome/browser/metrics/thread_watcher.cc
diff --git a/chrome/browser/metrics/thread_watcher.cc b/chrome/browser/metrics/thread_watcher.cc
index d2b62532fed08b67b75d19ed4de906b850cba280..341e3fc0daff76948df14d42ad37b53a0caf69e1 100644
--- a/chrome/browser/metrics/thread_watcher.cc
+++ b/chrome/browser/metrics/thread_watcher.cc
@@ -40,35 +40,35 @@ MSVC_PUSH_DISABLE_WARNING(4748)
 #endif
 
 void ThreadUnresponsive_UI() {
-  CHECK(false);
+  CHECK(false) << __FUNCTION__;

[eroman, 2012/07/03 19:00:38]

I am slightly surprised that CHECK(false) doesn't already generate unique
bodies. Since CHECK() macro will include the filename and line number, and the
line numbers should be different for each of the CHECK().

I suspect NOINLINE may be necessary here instead, but if this works then fine!

[Robert Sesek, 2012/07/10 18:43:09]

In official release builds, it looks like CHECK() gets turned into
base::debug::BreakDebugger, which won't generate the file/line data.

[jar (doing other things), 2012/07/10 20:05:23]

Reading the header file, it appears that they discard as much as possible to
avoid bloating the binary.  The approach you've taken here, reverses this trend,
and tries to force unique string names (function names) into the binary.   In
fact, it uses more memory than __FILE__ plus __LINE__ would, as the __FILE__
string would be shared in a const data segment, and only appear once.

Although the total memory used by your pattern in this case is not that great (a
couple of hundred bytes), the pattern seems worse than the segv approach I
mentioned.

Is there a reason why you prefer this that I'm missing?

 }
 
 void ThreadUnresponsive_DB() {
-  CHECK(false);
+  CHECK(false) << __FUNCTION__;
 }
 
 void ThreadUnresponsive_WEBKIT() {
-  CHECK(false);
+  CHECK(false) << __FUNCTION__;
 }
 
 void ThreadUnresponsive_FILE() {
-  CHECK(false);
+  CHECK(false) << __FUNCTION__;
 }
 
 void ThreadUnresponsive_FILE_USER_BLOCKING() {
-  CHECK(false);
+  CHECK(false) << __FUNCTION__;
 }
 
 void ThreadUnresponsive_PROCESS_LAUNCHER() {
-  CHECK(false);
+  CHECK(false) << __FUNCTION__;
 }
 
 void ThreadUnresponsive_CACHE() {
-  CHECK(false);
+  CHECK(false) << __FUNCTION__;
 }
 
 void ThreadUnresponsive_IO() {
-  CHECK(false);
+  CHECK(false) << __FUNCTION__;
 }
 
 #if defined(COMPILER_MSVC)
@@ -104,7 +104,7 @@ void CrashBecauseThreadWasUnresponsive(BrowserThread::ID thread_id) {
     // should warn if our switch becomes outdated.
   }
 
-  CHECK(false);  // Shouldn't be reached.
+  CHECK(false) << "Unknown thread was unresponsive.";  // Shouldn't be reached.
 }
 
 }  // namespace