Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 10700074: Do not add 'cloudPrintID' in print preview settings, if the print destination is local. (Closed)

Created:
8 years, 5 months ago by kmadhusu
Modified:
8 years, 5 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Do not add 'cloudPrintID' in print preview settings, if the print destination is local. BUG=135374 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145341

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/resources/print_preview/native_layer.js View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kmadhusu
Fixed a regression caused by print preview refactoring. We some how missed this during our ...
8 years, 5 months ago (2012-07-03 02:01:17 UTC) #1
Albert Bodenhamer
lgtm Thanks for catching this.
8 years, 5 months ago (2012-07-03 15:58:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/10700074/1
8 years, 5 months ago (2012-07-03 16:24:47 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-03 18:43:32 UTC) #4
Change committed as 145341

Powered by Google App Engine
This is Rietveld 408576698