Issue 10700058: Open/save dialog assumes the defaultPath parameter without '/' as a default file name.

Issue 10700058: Open/save dialog assumes the defaultPath parameter without '/' as a default file name. (Closed)

Created:
8 years, 5 months ago by SeRya

Modified:
8 years, 5 months ago

Reviewers:
dgozman, Ben Goodger (Google)

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Open/save dialog assumes the defaultPath parameter without '/' as a default file name. BUG=134578 TEST=Manual test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146147

Patch Set 2 : Adding leading slash to defaultPath. #

Patch Set 3 : Merge #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	chrome/browser/resources/file_manager/js/file_manager.js	View	1 2	2 chunks	+4 lines, -5 lines	0 comments	Download
	M	chrome/browser/ui/views/select_file_dialog_extension.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

dgozman

http://codereview.chromium.org/10700058/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (left): http://codereview.chromium.org/10700058/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#oldcode22 chrome/browser/resources/file_manager/js/file_manager.js:22: if (this.params_.defaultPath && this.params_.defaultPath.indexOf('/') != 0) Sometimes save-as dialog ...

8 years, 5 months ago (2012-07-02 12:38:47 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/10700058/11001

8 years, 5 months ago (2012-07-11 16:40:49 UTC) #8

Change committed as 146147

Expand Messages | Collapse Messages