Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10700039: Update the JSON Schema Compiler to take dependencies of the form type:name. (Closed)

Created:
8 years, 5 months ago by mitchellwrosen
Modified:
8 years, 5 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Update the JSON Schema Compiler to take dependencies of the form type:name. BUG=135224 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145235

Patch Set 1 #

Total comments: 1

Patch Set 2 : --find() ++split() #

Total comments: 2

Patch Set 3 : Nits #

Patch Set 4 : Sync with trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M tools/json_schema_compiler/compiler.py View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mitchellwrosen
8 years, 5 months ago (2012-06-29 18:36:52 UTC) #1
Aaron Boodman
https://chromiumcodereview.appspot.com/10700039/diff/1/tools/json_schema_compiler/compiler.py File tools/json_schema_compiler/compiler.py (right): https://chromiumcodereview.appspot.com/10700039/diff/1/tools/json_schema_compiler/compiler.py#newcode60 tools/json_schema_compiler/compiler.py:60: index = referenced_schema.find(':') split() ?
8 years, 5 months ago (2012-07-02 22:47:40 UTC) #2
mitchellwrosen
8 years, 5 months ago (2012-07-02 23:18:20 UTC) #3
Aaron Boodman
lgtm https://chromiumcodereview.appspot.com/10700039/diff/4001/tools/json_schema_compiler/compiler.py File tools/json_schema_compiler/compiler.py (right): https://chromiumcodereview.appspot.com/10700039/diff/4001/tools/json_schema_compiler/compiler.py#newcode60 tools/json_schema_compiler/compiler.py:60: split_schema = referenced_schema.split(':') split(':', 1) https://chromiumcodereview.appspot.com/10700039/diff/4001/tools/json_schema_compiler/compiler.py#newcode61 tools/json_schema_compiler/compiler.py:61: if ...
8 years, 5 months ago (2012-07-02 23:25:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mitchellwrosen@chromium.org/10700039/7002
8 years, 5 months ago (2012-07-02 23:29:15 UTC) #5
commit-bot: I haz the power
Try job failure for 10700039-7002 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 5 months ago (2012-07-03 00:11:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mitchellwrosen@chromium.org/10700039/5002
8 years, 5 months ago (2012-07-03 00:20:23 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-03 01:23:42 UTC) #8 
Change committed as 145235

Powered by Google App Engine
This is Rietveld 408576698