Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 10700037: Add trybot compiler/tester annotator scripts (Closed)

Created:
8 years, 5 months ago by Isaac (away)
Modified:
8 years, 5 months ago
Reviewers:
John Grabowski, Yaron
CC:
chromium-reviews
Visibility:
Public.

Description

Add trybot compiler/tester annotator scripts These are not currently called. Hooks will be added in a later CL. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145050

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
A + build/android/buildbot_try_compiler.sh View 1 chunk +6 lines, -4 lines 2 comments Download
A + build/android/buildbot_try_tester.sh View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Isaac (away)
8 years, 5 months ago (2012-06-29 18:23:46 UTC) #1
Yaron
lgtm
8 years, 5 months ago (2012-06-29 21:49:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/10700037/1
8 years, 5 months ago (2012-06-29 21:50:16 UTC) #3
commit-bot: I haz the power
Try job failure for 10700037-1 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 5 months ago (2012-06-29 22:29:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/10700037/1
8 years, 5 months ago (2012-06-30 00:43:12 UTC) #5
commit-bot: I haz the power
Change committed as 145050
8 years, 5 months ago (2012-06-30 02:01:19 UTC) #6
John Grabowski
like https://chromiumcodereview.appspot.com/10700037/diff/1/build/android/buildbot_try_compiler.sh File build/android/buildbot_try_compiler.sh (right): https://chromiumcodereview.appspot.com/10700037/diff/1/build/android/buildbot_try_compiler.sh#newcode19 build/android/buildbot_try_compiler.sh:19: bb_zip_build should we add a function called bb_trigger_tester? ...
8 years, 5 months ago (2012-07-10 23:38:16 UTC) #7
Isaac (away)
8 years, 5 months ago (2012-07-10 23:41:20 UTC) #8
https://chromiumcodereview.appspot.com/10700037/diff/1/build/android/buildbot...
File build/android/buildbot_try_compiler.sh (right):

https://chromiumcodereview.appspot.com/10700037/diff/1/build/android/buildbot...
build/android/buildbot_try_compiler.sh:19: bb_zip_build
On 2012/07/10 23:38:16, John Grabowski wrote:
> should we add a function called bb_trigger_tester?
> Seems logically distinct from "zip_build"

Agreed.  But the trigger step happens in buildbot code, not the annotation
script.  It's specified in master.cfg and ChromiumAnnotationFactory.

Powered by Google App Engine
This is Rietveld 408576698