Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 10700035: When fetching origins from the quota database, include the ones where the modification time exactly… (Closed)

Created:
8 years, 5 months ago by Bernhard Bauer
Modified:
8 years, 5 months ago
Reviewers:
michaeln
CC:
chromium-reviews, darin-cc_chromium.org, kinuko
Visibility:
Public.

Description

When fetching origins from the quota database, include the ones where the modification time exactly matches the beginning. This includes origins with modification time 0 in the result when fetching origins "since the beginning of time". BUG=134825 TEST=content_unittests:QuotaDatabaseTest.OriginLastModifiedSince; manual: Database storage is deleted from the Clear Browsing Data dialog. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146102

Patch Set 1 #

Patch Set 2 : unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M webkit/quota/quota_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/quota/quota_database_unittest.cc View 1 2 chunks +18 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bernhard Bauer
Please review.
8 years, 5 months ago (2012-06-29 16:49:39 UTC) #1
michaeln
This change lgtm... But are we not setting the last modified timestamp properly in some ...
8 years, 5 months ago (2012-07-09 18:26:27 UTC) #2
Bernhard Bauer
On 2012/07/09 18:26:27, michaeln wrote: > This change lgtm... > > But are we not ...
8 years, 5 months ago (2012-07-09 18:53:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10700035/2001
8 years, 5 months ago (2012-07-11 09:59:25 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 11:21:19 UTC) #5
Change committed as 146102

Powered by Google App Engine
This is Rietveld 408576698