Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Unified Diff: vm/flow_graph_compiler.cc

Issue 10700034: Add a goto instruction to the IL use it to terminate basic blocks. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: vm/flow_graph_compiler.cc
===================================================================
--- vm/flow_graph_compiler.cc (revision 9101)
+++ vm/flow_graph_compiler.cc (working copy)
@@ -91,9 +91,11 @@
// Compile all successors until an exit, branch, or a block entry.
while ((instr != NULL) && !instr->IsBlockEntry()) {
if (FLAG_code_comments) EmitComment(instr);
- ASSERT(instr->locs() != NULL);
- EmitInstructionPrologue(instr);
- instr->EmitNativeCode(this);
+ ASSERT(instr->IsGoto() || instr->locs() != NULL);
+ if (instr->locs() != NULL) {
+ EmitInstructionPrologue(instr);
+ instr->EmitNativeCode(this);
+ }
instr = instr->StraightLineSuccessor();
}
BlockEntryInstr* successor =

Powered by Google App Engine
This is Rietveld 408576698