Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10700027: browser: Move global error to subdir. (Closed)

Created:
8 years, 5 months ago by tfarina
Modified:
8 years, 5 months ago
CC:
chromium-reviews, ncarter (slow), mihaip-chromium-reviews_chromium.org, akalin, Raghu Simha, Aaron Boodman, tim (not reviewing)
Visibility:
Public.

Description

browser: Move global error to subdir. chrome/browser/ui/global_error* -> chrome/browser/ui/global_error/global_error* BUG=135018 R=ben@chromium.org TBR=atwilson@chromium.org,ivankr@chromium.org,willchan@chromim.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144952

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -826 lines) Patch
M chrome/browser/extensions/extension_disabled_ui.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_disabled_ui_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_global_error.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_global_error.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_global_error_badge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_system_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_warning_set.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_warning_set_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/first_run/first_run.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/protector/protector_service_browsertest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/protector/protector_service_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/protector/settings_change_global_error.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/protector/settings_change_global_error.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_global_error.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_global_error.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/global_error_bubble_controller.mm View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 chunk +3 lines, -3 lines 0 comments Download
D chrome/browser/ui/global_error.h View 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/browser/ui/global_error.cc View 1 chunk +0 lines, -50 lines 0 comments Download
A + chrome/browser/ui/global_error/global_error.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/global_error/global_error.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/global_error/global_error_bubble_view_base.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/global_error/global_error_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/global_error/global_error_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/global_error/global_error_service_browsertest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/global_error/global_error_service_factory.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/global_error/global_error_service_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/global_error/global_error_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/global_error_bubble_view_base.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/ui/global_error_service.h View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/ui/global_error_service.cc View 1 chunk +0 lines, -85 lines 0 comments Download
D chrome/browser/ui/global_error_service_browsertest.cc View 1 chunk +0 lines, -150 lines 0 comments Download
D chrome/browser/ui/global_error_service_factory.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/ui/global_error_service_factory.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/ui/global_error_service_unittest.cc View 1 chunk +0 lines, -195 lines 0 comments Download
M chrome/browser/ui/gtk/browser_toolbar_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/global_error_bubble.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/global_error_bubble.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/global_error_bubble_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/global_error_bubble_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
8 years, 5 months ago (2012-06-28 23:56:28 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 5 months ago (2012-06-29 15:49:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/10700027/1
8 years, 5 months ago (2012-06-29 17:42:28 UTC) #3
commit-bot: I haz the power
Presubmit check for 10700027-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-06-29 17:42:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/10700027/1
8 years, 5 months ago (2012-06-29 17:46:09 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-06-29 19:11:42 UTC) #6 
Change committed as 144952

Powered by Google App Engine
This is Rietveld 408576698