Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1371)

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.h

Issue 10700024: Revert 144807 - Rewrite DownloadsApiTest in C++. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/downloads/downloads_api.h
===================================================================
--- chrome/browser/extensions/api/downloads/downloads_api.h (revision 144812)
+++ chrome/browser/extensions/api/downloads/downloads_api.h (working copy)
@@ -42,7 +42,7 @@
extern const char kInvalidOrderByError[];
extern const char kInvalidQueryLimit[];
extern const char kInvalidStateError[];
-extern const char kInvalidURLError[];
+extern const char kInvalidUrlError[];
extern const char kNotImplementedError[];
} // namespace download_extension_errors
@@ -350,8 +350,7 @@
class ExtensionDownloadsEventRouter : public content::DownloadManager::Observer,
public content::DownloadItem::Observer {
public:
- explicit ExtensionDownloadsEventRouter(
- Profile* profile, content::DownloadManager* manager);
+ explicit ExtensionDownloadsEventRouter(Profile* profile);
virtual ~ExtensionDownloadsEventRouter();
virtual void ModelChanged(content::DownloadManager* manager) OVERRIDE;
@@ -359,12 +358,6 @@
virtual void OnDownloadUpdated(content::DownloadItem* download) OVERRIDE;
virtual void OnDownloadOpened(content::DownloadItem* download) OVERRIDE;
- // Used for testing.
- struct DownloadsNotificationSource {
- std::string event_name;
- Profile* profile;
- };
-
private:
struct OnChangedStat {
OnChangedStat();
@@ -377,6 +370,7 @@
typedef std::map<int, base::DictionaryValue*> ItemJsonMap;
typedef std::map<int, OnChangedStat*> OnChangedStatMap;
+ void Init(content::DownloadManager* manager);
void DispatchEvent(const char* event_name, base::Value* json_arg);
Profile* profile_;
« no previous file with comments | « chrome/browser/download/chrome_download_manager_delegate.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698