Issue 10700022: Add in support for components build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10700022: Add in support for components build. (Closed)

Created:
8 years, 5 months ago by awong

Modified:
8 years, 5 months ago

Reviewers:
cmp

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add in support for components build. BUG=none TEST=tested locally on a chrome binary from a components build. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144835

Patch Set 2 : Fix log messages. #

Patch Set 3 : Fix more comments. #

Total comments: 2

Patch Set 4 : fix nits #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -11 lines)			Patch
	M	build/gdb-add-index	View	1 2 3	2 chunks	+44 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cmp

lgtm with nit https://chromiumcodereview.appspot.com/10700022/diff/3001/build/gdb-add-index File build/gdb-add-index (right): https://chromiumcodereview.appspot.com/10700022/diff/3001/build/gdb-add-index#newcode46 build/gdb-add-index:46: rm -f "${file}.gdb-index" for lines 44-46, ...

8 years, 5 months ago (2012-06-28 21:50:16 UTC) #2

awong

8 years, 5 months ago (2012-06-28 23:23:20 UTC) #3

http://codereview.chromium.org/10700022/diff/3001/build/gdb-add-index
File build/gdb-add-index (right):

http://codereview.chromium.org/10700022/diff/3001/build/gdb-add-index#newcode46
build/gdb-add-index:46: rm -f "${file}.gdb-index"
On 2012/06/28 21:50:16, cmp wrote:
> for lines 44-46, remove one space from indent

Fixed.  Committing after clean try-bot run (I skipped the try box last time and
the check-in actually broke something :-/ )