Make per-interface generators an implementation detail of a system.

lib/dom/scripts/systeminterface.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module providesfunctionality for systems to generate
 Dart interfaces from the IDL database."""
 
 import os
 import systembase
 from generator import *
 
 class InterfacesSystem(systembase.System):
 
   def __init__(self, templates, database, emitters, output_dir):
     super(InterfacesSystem, self).__init__(
         templates, database, emitters, output_dir)
     self._dart_interface_file_paths = []
 
 
-  def InterfaceGenerator(self,
-                         interface,
-                         common_prefix,
-                         super_interface_name,
-                         source_filter):
+  def ProcessInterface(self, interface):
     """."""
     interface_name = interface.id
     dart_interface_file_path = self._FilePathForDartInterface(interface_name)
 
     self._dart_interface_file_paths.append(dart_interface_file_path)
 
     dart_interface_code = self._emitters.FileEmitter(dart_interface_file_path)
 
     template_file = 'interface_%s.darttemplate' % interface_name
     template = self._templates.TryLoad(template_file)
     if not template:
       template = self._templates.Load('interface.darttemplate')
 
-    return DartInterfaceGenerator(
-        self, interface, dart_interface_code,
-        template,
-        common_prefix, super_interface_name,
-        source_filter)
+    generator = DartInterfaceGenerator(
+        self, interface, dart_interface_code, template)
+    generator.Generate()
 
   def ProcessCallback(self, interface, info):
     """Generates a typedef for the callback interface."""
     interface_name = interface.id
     file_path = self._FilePathForDartInterface(interface_name)
     self._ProcessCallback(interface, info, file_path)
 
   def GenerateLibraries(self):
     pass
 
 
   def _FilePathForDartInterface(self, interface_name):
     """Returns the file path of the Dart interface definition."""
     return os.path.join(self._output_dir, 'src', 'interface',
                         '%s.dart' % interface_name)
 
 # ------------------------------------------------------------------------------
 
 class DartInterfaceGenerator(systembase.BaseGenerator):
   """Generates Dart Interface definition for one DOM IDL interface."""
 
-  def __init__(self, system, interface, emitter, template,
-               common_prefix, super_interface, source_filter):
+  def __init__(self, system, interface, emitter, template):
     """Generates Dart code for the given interface.
 
     Args:
       interface -- an IDLInterface instance. It is assumed that all types have
         been converted to Dart types (e.g. int, String), unless they are in the
         same package as the interface.
-      common_prefix -- the prefix for the common library, if any.
       super_interface -- the name of the common interface that this interface
         implements, if any.
-      source_filter -- if specified, rewrites the names of any superinterfaces
-        that are not from these sources to use the common prefix.
     """
-    super(DartInterfaceGenerator, self).__init__(system._database)
+    super(DartInterfaceGenerator, self).__init__(system._database, interface)
     self._system = system
-    self._interface = interface
     self._emitter = emitter
     self._template = template
-    self._common_prefix = common_prefix
-    self._super_interface = super_interface
-    self._source_filter = source_filter
-
+    self._super_interface = interface.ext_attrs.get(
+        'synthesizedSuperInterfaceName', None)
 
   def StartInterface(self):
     if self._super_interface:
       typename = self._super_interface
     else:
       typename = self._interface.id
 
 
     extends = []
     suppressed_extends = []
 
     for parent in self._interface.parents:
       # TODO(vsm): Remove source_filter.
-      if MatchSourceFilter(self._source_filter, parent):
+      if MatchSourceFilter(parent):
         # Parent is a DOM type.
         extends.append(DartType(parent.type.id))
       elif '<' in parent.type.id:
         # Parent is a Dart collection type.
         # TODO(vsm): Make this check more robust.
         extends.append(parent.type.id)
       else:
         suppressed_extends.append('%s.%s' %
                                   (self._common_prefix, parent.type.id))
 
@@ skipping 92 matching lines @@
     """
     Arguments:
       operations - contains the overloads, one or more operations with the same
         name.
     """
     self._members_emitter.Emit('\n'
                                '  $TYPE $NAME($PARAMS);\n',
                                TYPE=info.type_name,
                                NAME=info.name,
                                PARAMS=info.ParametersInterfaceDeclaration())