Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: tools/testing/drt-trampoline.py

Issue 10699078: Try to speed up output piping. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/drt-trampoline.py
diff --git a/tools/testing/drt-trampoline.py b/tools/testing/drt-trampoline.py
index a576097ad6c081aa3bce37283ccdf044787366d5..1bb525cc931deba08ce29cbd55a285f025c55ed1 100644
--- a/tools/testing/drt-trampoline.py
+++ b/tools/testing/drt-trampoline.py
@@ -48,7 +48,8 @@ def main(argv):
cmd.append(arg)
- p = subprocess.Popen(cmd, env=env, stdout=subprocess.PIPE)
+ stdout = subprocess.PIPE if out_expected_file else None
+ p = subprocess.Popen(cmd, env=env, stdout=stdout)
output, error = p.communicate()
if p.returncode != 0:
raise Exception('Failed to run command. return code=%s' % p.returncode)
@@ -85,9 +86,6 @@ def main(argv):
print 'Expectation didn\'t match. Update expectations by running:\n'
print 'cp %s %s\n' % (out_file, out_expected_file)
print '#EOF'
- else:
- # Pipe through the output for non-layout tests.
- print output
if __name__ == '__main__':
try:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698