Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 10699057: Move application creation and extension install prompt showing off Browser and onto ExtensionTabHel… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_commands.h ('k') | chrome/browser/ui/browser_dialogs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_commands.cc
===================================================================
--- chrome/browser/ui/browser_commands.cc (revision 145357)
+++ chrome/browser/ui/browser_commands.cc (working copy)
@@ -15,6 +15,7 @@
#include "chrome/browser/debugger/devtools_window.h"
#include "chrome/browser/download/download_util.h"
#include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/extension_tab_helper.h"
#include "chrome/browser/favicon/favicon_tab_helper.h"
#include "chrome/browser/lifetime/application_lifetime.h"
#include "chrome/browser/platform_util.h"
@@ -922,8 +923,15 @@
return chrome::GetActiveWebContents(browser)->GetController().CanViewSource();
}
+void CreateApplicationShortcuts(Browser* browser) {
+ content::RecordAction(UserMetricsAction("CreateShortcut"));
+ chrome::GetActiveTabContents(browser)->extension_tab_helper()->
+ CreateApplicationShortcuts();
+}
+
bool CanCreateApplicationShortcuts(const Browser* browser) {
- return web_app::IsValidUrl(chrome::GetActiveWebContents(browser)->GetURL());
+ return chrome::GetActiveTabContents(browser)->extension_tab_helper()->
+ CanCreateApplicationShortcuts();
}
void ConvertTabToAppWindow(Browser* browser,
« no previous file with comments | « chrome/browser/ui/browser_commands.h ('k') | chrome/browser/ui/browser_dialogs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698