Don't actually create Handles for the constant hole.

src/hydrogen.cc

Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index ee3d6b5cfb632effc8ac270dfdeeed222528cdf0..c43f9364d12591a9cad4db5e309fea15c655bebb 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -568,9 +568,9 @@ void HGraph::Verify(bool do_full_verify) const {
 
 
 HConstant* HGraph::GetConstant(SetOncePointer<HConstant>* pointer,
-                               Object* value) {
+                               Handle<Object> value) {
   if (!pointer->is_set()) {
-    HConstant* constant = new(zone()) HConstant(Handle<Object>(value),
+    HConstant* constant = new(zone()) HConstant(value,
                                                 Representation::Tagged());
     constant->InsertAfter(GetConstantUndefined());
     pointer->set(constant);
@@ -580,27 +580,33 @@ HConstant* HGraph::GetConstant(SetOncePointer<HConstant>* pointer,
 
 
 HConstant* HGraph::GetConstant1() {
-  return GetConstant(&constant_1_, Smi::FromInt(1));
+  return GetConstant(&constant_1_, Handle<Smi>(Smi::FromInt(1)));
 }
 
 
 HConstant* HGraph::GetConstantMinus1() {
-  return GetConstant(&constant_minus1_, Smi::FromInt(-1));
+  return GetConstant(&constant_minus1_, Handle<Smi>(Smi::FromInt(-1)));
 }
 
 
 HConstant* HGraph::GetConstantTrue() {
-  return GetConstant(&constant_true_, isolate()->heap()->true_value());
+  return GetConstant(&constant_true_, isolate()->factory()->true_value());
 }
 
 
 HConstant* HGraph::GetConstantFalse() {
-  return GetConstant(&constant_false_, isolate()->heap()->false_value());
+  return GetConstant(&constant_false_, isolate()->factory()->false_value());
 }
 
 
 HConstant* HGraph::GetConstantHole() {
-  return GetConstant(&constant_hole_, isolate()->heap()->the_hole_value());
+  if (!constant_hole_.is_set()) {

[Michael Starzinger, 2012/07/03 09:20:09]

Is there a particular reason we need the special handling for the hole value?
Can't we just use GetConstant() instead of this whole block now?

[sanjoy, 2012/07/03 09:32:00]

No there isn't and yes we should.  Fixed.

+    HConstant* constant = new(zone()) HConstant(
+        isolate()->factory()->the_hole_value(), Representation::Tagged());
+    constant->InsertAfter(GetConstantUndefined());
+    constant_hole_.set(constant);
+  }
+  return constant_hole_.get();
 }