Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: chrome/browser/ui/chrome_pages.cc

Issue 10699039: Switch to using the WebUI About screen on Windows. Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/webui/help/help_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/chrome_pages.h" 5 #include "chrome/browser/ui/chrome_pages.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/string_number_conversions.h" 8 #include "base/string_number_conversions.h"
9 #include "base/stringprintf.h" 9 #include "base/stringprintf.h"
10 #include "chrome/browser/download/download_shelf.h" 10 #include "chrome/browser/download/download_shelf.h"
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 content::RecordAction(UserMetricsAction("Import_ShowDlg")); 152 content::RecordAction(UserMetricsAction("Import_ShowDlg"));
153 ShowSettingsSubPage(browser, kImportDataSubPage); 153 ShowSettingsSubPage(browser, kImportDataSubPage);
154 } 154 }
155 155
156 void ShowInstantConfirmDialog(Browser* browser) { 156 void ShowInstantConfirmDialog(Browser* browser) {
157 ShowSettingsSubPage(browser, kInstantConfirmPage); 157 ShowSettingsSubPage(browser, kInstantConfirmPage);
158 } 158 }
159 159
160 void ShowAboutChrome(Browser* browser) { 160 void ShowAboutChrome(Browser* browser) {
161 content::RecordAction(UserMetricsAction("AboutChrome")); 161 content::RecordAction(UserMetricsAction("AboutChrome"));
162 #if !defined(OS_WIN)
163 browser::NavigateParams params( 162 browser::NavigateParams params(
164 GetSingletonTabNavigateParams(browser, GURL(kChromeUIUberURL))); 163 GetSingletonTabNavigateParams(browser, GURL(kChromeUIUberURL)));
165 params.path_behavior = browser::NavigateParams::IGNORE_AND_NAVIGATE; 164 params.path_behavior = browser::NavigateParams::IGNORE_AND_NAVIGATE;
166 ShowSingletonTabOverwritingNTP(browser, params); 165 ShowSingletonTabOverwritingNTP(browser, params);
167 #else
168 // crbug.com/115123.
169 browser->window()->ShowAboutChromeDialog();
170 #endif
171 } 166 }
172 167
173 void ShowSearchEngineSettings(Browser* browser) { 168 void ShowSearchEngineSettings(Browser* browser) {
174 content::RecordAction(UserMetricsAction("EditSearchEngines")); 169 content::RecordAction(UserMetricsAction("EditSearchEngines"));
175 ShowSettingsSubPage(browser, kSearchEnginesSubPage); 170 ShowSettingsSubPage(browser, kSearchEnginesSubPage);
176 } 171 }
177 172
178 void ShowSyncSetup(Browser* browser, SyncPromoUI::Source source) { 173 void ShowSyncSetup(Browser* browser, SyncPromoUI::Source source) {
179 ProfileSyncService* service = 174 ProfileSyncService* service =
180 ProfileSyncServiceFactory::GetInstance()->GetForProfile( 175 ProfileSyncServiceFactory::GetInstance()->GetForProfile(
(...skipping 10 matching lines...) Expand all
191 GetSingletonTabNavigateParams(browser, GURL(url))); 186 GetSingletonTabNavigateParams(browser, GURL(url)));
192 params.path_behavior = browser::NavigateParams::IGNORE_AND_NAVIGATE; 187 params.path_behavior = browser::NavigateParams::IGNORE_AND_NAVIGATE;
193 ShowSingletonTabOverwritingNTP(browser, params); 188 ShowSingletonTabOverwritingNTP(browser, params);
194 } else { 189 } else {
195 LoginUIServiceFactory::GetForProfile( 190 LoginUIServiceFactory::GetForProfile(
196 browser->profile()->GetOriginalProfile())->ShowLoginUI(); 191 browser->profile()->GetOriginalProfile())->ShowLoginUI();
197 } 192 }
198 } 193 }
199 194
200 } // namespace chrome 195 } // namespace chrome
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/webui/help/help_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698