Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Issue 10699033: Animation the script badges on views. (Closed)

Created:
8 years, 5 months ago by not at google - send to devlin
Modified:
8 years, 5 months ago
CC:
chromium-reviews, benwells, koz (OOO until 15th September)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Animation the script badges on views. BUG=133141 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145991

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -9 lines) Patch
M chrome/browser/ui/views/location_bar/page_action_image_view.h View 4 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 4 chunks +23 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
not at google - send to devlin
Hi Scott This is the views component of http://codereview.chromium.org/10559054/.
8 years, 5 months ago (2012-06-29 07:15:16 UTC) #1
not at google - send to devlin
Redirecting to ben@ since it looks like sky@ is OOO.
8 years, 5 months ago (2012-07-04 00:45:22 UTC) #2
not at google - send to devlin
Ping, anybody around?
8 years, 5 months ago (2012-07-10 04:54:05 UTC) #3
Ben Goodger (Google)
lgtm
8 years, 5 months ago (2012-07-10 15:13:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/10699033/1
8 years, 5 months ago (2012-07-10 22:42:58 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-10 23:40:06 UTC) #6
Change committed as 145991

Powered by Google App Engine
This is Rietveld 408576698