Issue 10699032: autocomplete: Extract AutocompleteResult from autocomplete.*.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+643 lines, -610 lines)			Patch
M	chrome/browser/autocomplete/autocomplete.h	View	1 2 3 4 5 6	2 chunks	+0 lines, -317 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete.cc	View		2 chunks	+1 line, -252 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_controller.h	View	1 2 3 4 5 6	2 chunks	+19 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_provider.h	View	1 2 3 4 5 6	1 chunk	+147 lines, -0 lines	0 comments	Download
A	chrome/browser/autocomplete/autocomplete_result.h	View		1 chunk	+162 lines, -0 lines	0 comments	Download
A	chrome/browser/autocomplete/autocomplete_result.cc	View	1	1 chunk	+250 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_result_unittest.cc	View	1 2 3 4 5	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/history_quick_provider.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/history_quick_provider_unittest.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/search_provider.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/search_provider.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/shortcuts_provider.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/history/shortcuts_backend.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/metrics/metrics_log.cc	View	1 2 3 4 5 6	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/omnibox_search_hint.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/predictors/autocomplete_action_predictor.cc	View	1 2 3 4	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/webui/omnibox/omnibox_ui_handler.h	View	1 2 3	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/display_options_handler.h	View	1 2 3	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/display_options_handler.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options2/content_settings_handler2.h	View	1 2 3	3 chunks	+13 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/options_ui2.h	View		3 chunks	+11 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/options_ui2.cc	View		5 chunks	+12 lines, -13 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4 5 6	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

8 years, 5 months ago (2012-07-02 19:15:06 UTC) #2

LGTM

http://codereview.chromium.org/10699032/diff/5005/chrome/browser/autocomplete...
File chrome/browser/autocomplete/autocomplete.h (right):

http://codereview.chromium.org/10699032/diff/5005/chrome/browser/autocomplete...
chrome/browser/autocomplete/autocomplete.h:16: // The AutocompleteController is
the center of the autocomplete system.  A
Nit: Can you move these first three paragraphs to autocomplete_controller.h?

http://codereview.chromium.org/10699032/diff/5005/chrome/browser/autocomplete...
chrome/browser/autocomplete/autocomplete.h:34: // The AutocompleteProviders each
return different kinds of matches,
Nit: And then move the rest of this top set of comments into
autocomplete_provider.h?

Expand Messages | Collapse Messages