Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 10699025: Test scripts: Fix a missing Path.toNativePath() in reading status files for tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 // [forDirectory] adds name_dart2js.status for all tests suites, use it if 322 // [forDirectory] adds name_dart2js.status for all tests suites, use it if
323 // it exists, but otherwise skip it and don't fail. 323 // it exists, but otherwise skip it and don't fail.
324 if (statusFilePath.endsWith('_dart2js.status')) { 324 if (statusFilePath.endsWith('_dart2js.status')) {
325 File file = new File.fromPath(dartDir.append(statusFilePath)); 325 File file = new File.fromPath(dartDir.append(statusFilePath));
326 if (!file.existsSync()) { 326 if (!file.existsSync()) {
327 filesRead++; 327 filesRead++;
328 continue; 328 continue;
329 } 329 }
330 } 330 }
331 ReadTestExpectationsInto(testExpectations, 331 ReadTestExpectationsInto(testExpectations,
332 dartDir.append(statusFilePath).toString(), 332 dartDir.append(statusFilePath).toNativePath(),
333 configuration, 333 configuration,
334 statusFileRead); 334 statusFileRead);
335 } 335 }
336 } 336 }
337 337
338 void processDirectory() { 338 void processDirectory() {
339 Directory dir = new Directory.fromPath(suiteDir); 339 Directory dir = new Directory.fromPath(suiteDir);
340 dir.exists().then((exists) { 340 dir.exists().then((exists) {
341 if (!exists) { 341 if (!exists) {
342 print('Directory containing tests not found: $suiteDir'); 342 print('Directory containing tests not found: $suiteDir');
(...skipping 980 matching lines...) Expand 10 before | Expand all | Expand 10 after
1323 * $noCrash tests are expected to be flaky but not crash 1323 * $noCrash tests are expected to be flaky but not crash
1324 * $pass tests are expected to pass 1324 * $pass tests are expected to pass
1325 * $failOk tests are expected to fail that we won't fix 1325 * $failOk tests are expected to fail that we won't fix
1326 * $fail tests are expected to fail that we should fix 1326 * $fail tests are expected to fail that we should fix
1327 * $crash tests are expected to crash that we should fix 1327 * $crash tests are expected to crash that we should fix
1328 * $timeout tests are allowed to timeout 1328 * $timeout tests are allowed to timeout
1329 """; 1329 """;
1330 print(report); 1330 print(report);
1331 } 1331 }
1332 } 1332 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698