Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 10699005: When a variable name is used as a type, emit a warning, not an error (Closed)

Created:
8 years, 5 months ago by zundel
Modified:
8 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, scheglov
Visibility:
Public.

Description

When a variable name is used as a type, emit a warning, not an error Issue 3474 http://code.google.com/p/dart/issues/detail?id=3474 Committed: https://code.google.com/p/dart/source/detail?r=9171

Patch Set 1 : Updated junit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -8 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java View 3 chunks +12 lines, -3 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 4 chunks +13 lines, -3 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
zundel
8 years, 5 months ago (2012-06-27 11:53:06 UTC) #1
Brian Wilkerson
8 years, 5 months ago (2012-06-27 14:02:44 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698