Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Unified Diff: runtime/vm/locations.h

Issue 10698153: Change comparison-to-branch fusion to actually remove comparison from the graph. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/locations.h
diff --git a/runtime/vm/locations.h b/runtime/vm/locations.h
index 8a869b3d0c2f416673896692ea14f916571122b9..232a7618a3c531ded3fdfd8eccce05ca50386acf 100644
--- a/runtime/vm/locations.h
+++ b/runtime/vm/locations.h
@@ -105,21 +105,14 @@ class LocationSummary : public ZoneAllocated {
kCall,
};
- enum ContainsBranch {
- kNoBranch,
- kBranch
- };
-
// TODO(vegorov): remove unsafe kNoCall default.
LocationSummary(intptr_t input_count,
intptr_t temp_count,
- ContainsCall call = kNoCall,
- ContainsBranch branch = kNoBranch)
+ ContainsCall call = kNoCall)
: input_locations_(input_count),
temp_locations_(temp_count),
output_location_(),
- is_call_(call == kCall),
- is_branch_(branch == kBranch) {
+ is_call_(call == kCall) {
for (intptr_t i = 0; i < input_count; i++) {
input_locations_.Add(Location());
}
@@ -164,17 +157,9 @@ class LocationSummary : public ZoneAllocated {
return is_call_;
}
- // TODO(vegorov): this is a temporary solution. Once we will start removing
- // comparison operations from the flow graph when they are fused with a branch
- // we should eliminate this.
- bool is_branch() const {
- return is_branch_;
- }
-
static LocationSummary* Make(intptr_t input_count,
Location out,
- ContainsCall contains_call = kNoCall,
- ContainsBranch contains_branch = kNoBranch);
+ ContainsCall contains_call = kNoCall);
private:
// TODO(vegorov): replace with ZoneArray.
@@ -183,7 +168,6 @@ class LocationSummary : public ZoneAllocated {
Location output_location_;
const bool is_call_;
- const bool is_branch_;
};

Powered by Google App Engine
This is Rietveld 408576698