Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: base/base.gypi

Issue 10698149: Add minimal support for process_utils on iOS (Closed) Base URL: http://git.chromium.org/chromium/src.git@all-ios-tweak
Patch Set: Address review comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/base.gypi
diff --git a/base/base.gypi b/base/base.gypi
index de1ebc768fddb2e9b2e2379360d4084dfc9bffca..6d0fe3633cbb28a400d5be1595b42fcf6f594d27 100644
--- a/base/base.gypi
+++ b/base/base.gypi
@@ -272,6 +272,7 @@
'process_util.cc',
'process_util.h',
'process_util_freebsd.cc',
+ 'process_util_ios.mm',
'process_util_linux.cc',
'process_util_mac.mm',
'process_util_openbsd.cc',
@@ -561,6 +562,8 @@
['include', '^file_util_mac\\.'],
['include', '^file_version_info_mac\\.'],
['include', '^mac/bundle_locations\\.'],
+ ['include', '^mac/foundation_util\\.'],
+ ['include', '^mac/mac_logging\\.'],
['include', '^mac/objc_property_releaser\\.'],
['include', '^mac/scoped_nsautorelease_pool\\.'],
['include', '^message_pump_mac\\.'],
@@ -569,11 +572,12 @@
['include', '^sys_string_conversions_mac\\.'],
['include', '^time_mac\\.'],
['include', '^worker_pool_mac\\.'],
- # TODO(ios): Remove these as base/ is unforked.
- # For now, exclude everything that doesn't build as-is, just to
- # get something building on a bot.
- ['exclude', '^message_pump'],
+ # Exclude all process_util except the minimal implementation
+ # needed on iOS (mostly for unit tests).
['exclude', '^process_util'],
+ ['include', '^process_util_ios.mm'],
Mark Mentovai 2012/07/11 14:04:22 (Double-)backslash that dot and gimme a dollar sig
stuartmorgan 2012/07/11 14:18:03 Done.
+ # TODO(ios): Add message_pump support.
+ ['exclude', '^message_pump'],
],
}],
['OS != "mac" or >(nacl_untrusted_build)==1', {
« no previous file with comments | « base/base.gyp ('k') | base/mac/foundation_util.h » ('j') | base/mac/foundation_util.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698