Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: tools/clang/plugins/FindBadConstructs.cpp

Issue 10698147: clang: Add missing 'virtual' keyword to some overridden functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/FindBadConstructs.cpp
diff --git a/tools/clang/plugins/FindBadConstructs.cpp b/tools/clang/plugins/FindBadConstructs.cpp
index 43d23c2f67f5c9089b9145d2d745056e0203d249..b79a64dbd19959bc449719681212961ed39b382b 100644
--- a/tools/clang/plugins/FindBadConstructs.cpp
+++ b/tools/clang/plugins/FindBadConstructs.cpp
@@ -399,13 +399,15 @@ class FindBadConstructsAction : public PluginASTAction {
}
protected:
- ASTConsumer* CreateASTConsumer(CompilerInstance &CI, llvm::StringRef ref) {
+ // Overridden from PluginASTAction:
+ virtual ASTConsumer* CreateASTConsumer(CompilerInstance& instance,
+ llvm::StringRef ref) {
return new FindBadConstructsConsumer(
- CI, check_refcounted_dtors_, check_virtuals_in_implementations_);
+ instance, check_refcounted_dtors_, check_virtuals_in_implementations_);
}
- bool ParseArgs(const CompilerInstance &CI,
- const std::vector<std::string>& args) {
+ virtual bool ParseArgs(const CompilerInstance& instance,
+ const std::vector<std::string>& args) {
bool parsed = true;
for (size_t i = 0; i < args.size() && parsed; ++i) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698