Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 10698147: clang: Add missing 'virtual' keyword to some overridden functions. (Closed)

Created:
8 years, 5 months ago by tfarina
Modified:
8 years, 5 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

clang: Add missing 'virtual' keyword to some overridden functions. R=erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146258

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M tools/clang/plugins/FindBadConstructs.cpp View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
8 years, 5 months ago (2012-07-11 05:22:48 UTC) #1
Elliot Glaysher
8 years, 5 months ago (2012-07-11 16:54:29 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698