Issue 10698146: Rename gfx_unittests with ui_unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10698146: Rename gfx_unittests with ui_unittests. (Closed)

Created:
8 years, 5 months ago by Hironori Bono

Modified:
8 years, 5 months ago

Reviewers:
Lei Zhang, Alexander Potapenko, Timur Iskhodzhanov

CC:
chromium-reviews, pam+watch_chromium.org, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Rename gfx_unittests with ui_unittests. This is a band-aid fix that runs ui_unittests when runing chrome_tests.sh with a '-t gfx' option. Also, it renames an exclude file to use it when running ui_unittests. BUG=none TEST=make valgrind and heapchecker bots green. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146081

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
M	tools/heapcheck/chrome_tests.py	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	tools/valgrind/chrome_tests.py	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
D	tools/valgrind/gtest_exclude/gfx_unittests.gtest-tsan.txt	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
A +	tools/valgrind/gtest_exclude/ui_unittests.gtest-tsan.txt	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hironori Bono

Greetings, This is a band-aid fix for r143648, which creates ui_unittests instead of gfx_unittests, without ...

8 years, 5 months ago (2012-07-11 02:52:41 UTC) #1

Timur Iskhodzhanov

Please add TODO comments mentioning that this is a band aid. Then LGTM assuming you're ...

8 years, 5 months ago (2012-07-11 05:11:47 UTC) #2

Hironori Bono

8 years, 5 months ago (2012-07-11 06:20:23 UTC) #3

Greetings Timur,

Thanks for your response. I have added TODO comments and also renamed an exclude
file so TSAN bots can use it when running ui_unittests.

Regards,

Hironori Bono

Expand Messages | Collapse Messages