Issue 10698143: browser: Remove web_dialog_view.h from DEPS whitelist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10698143: browser: Remove web_dialog_view.h from DEPS whitelist. (Closed)

Created:
8 years, 5 months ago by tfarina

Modified:
8 years, 5 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

browser: Remove web_dialog_view.h from DEPS whitelist. BUG=125846 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146048

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	chrome/browser/DEPS	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

8 years, 5 months ago (2012-07-11 15:58:17 UTC) #2

LGTM


On Tue, Jul 10, 2012 at 6:34 PM, <tfarina@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> TBRing...
>
> Description:
> browser: Remove web_dialog_view.h from DEPS whitelist.
>
> BUG=125846
> TBR=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/10698143/<http://codereview.chromium.org/106...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/browser/DEPS
>
>
> Index: chrome/browser/DEPS
> diff --git a/chrome/browser/DEPS b/chrome/browser/DEPS
> index 73317acfa867fe10f88257b60d6ef2**a6fcad2563..**
> bf67478cb65b70b109d3ab9d21b238**f06f25e74f 100644
> --- a/chrome/browser/DEPS
> +++ b/chrome/browser/DEPS
> @@ -50,7 +50,6 @@ include_rules = [
>    "+chrome/browser/ui/views/**reload_button.h",
>    "+chrome/browser/ui/views/**select_file_dialog_extension.**h",
>    "+chrome/browser/ui/views/**unhandled_keyboard_event_**handler.h",
> -  "+chrome/browser/ui/views/web_**dialog_view.h",
>    # DO NOT ADD ANY MORE ITEMS TO THE ABOVE LIST!
>
>    # Other libraries.
>
>
>

Expand Messages | Collapse Messages