Issue 10698140: Remove "2" suffixes from options2 code.

Issue 10698140: Remove "2" suffixes from options2 code. (Closed)

Created:
8 years, 5 months ago by Dan Beam

Modified:
8 years, 5 months ago

Reviewers:
Lei Zhang, csilv, sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove "2" suffixes from options2 code. BUG=None TEST=compiles, works, passes tests R=csilv@chromium.org,thestig@chromium.org TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146069

Patch Set 4 : copyright bump #

Patch Set 5 : rebase #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+370 lines, -17280 lines)			Patch
M	chrome/browser/chromeos/login/user_manager.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/chrome_pages.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/oobe_ui.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/proxy_settings_ui.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/advanced_options_utils.h	View	1 2 3	2 chunks	+4 lines, -4 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/advanced_options_utils2.h	View		1 chunk	+0 lines, -31 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/advanced_options_utils2_mac.mm	View		1 chunk	+0 lines, -48 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/advanced_options_utils2_win.cc	View		1 chunk	+0 lines, -73 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/advanced_options_utils2_x11.cc	View		1 chunk	+0 lines, -158 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/advanced_options_utils_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/browser/ui/webui/options2/advanced_options_utils_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/browser/ui/webui/options2/advanced_options_utils_x11.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/autofill_options2_browsertest.js	View	1 2	1 chunk	+0 lines, -24 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/autofill_options_browsertest.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/autofill_options_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/autofill_options_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/autofill_options_handler2.h	View		1 chunk	+0 lines, -97 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/autofill_options_handler2.cc	View		1 chunk	+0 lines, -628 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/browser_options2_browsertest.js	View	1 2	1 chunk	+0 lines, -31 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/browser_options_browsertest.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/browser_options_handler.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/browser_options_handler.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/browser_options_handler2.h	View		1 chunk	+0 lines, -328 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/browser_options_handler2.cc	View		1 chunk	+0 lines, -1454 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/certificate_manager2_browsertest.js	View	1 2	1 chunk	+0 lines, -34 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/certificate_manager_browsertest.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/certificate_manager_handler.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/certificate_manager_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/certificate_manager_handler2.h	View		1 chunk	+0 lines, -188 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/certificate_manager_handler2.cc	View		1 chunk	+0 lines, -1094 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/accounts_options_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/accounts_options_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/accounts_options_handler2.h	View		1 chunk	+0 lines, -42 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/accounts_options_handler2.cc	View		1 chunk	+0 lines, -139 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler2.h	View		1 chunk	+0 lines, -199 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler2.cc	View		1 chunk	+0 lines, -428 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler2.h	View		1 chunk	+0 lines, -136 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler2.cc	View		1 chunk	+0 lines, -422 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/core_chromeos_options_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/core_chromeos_options_handler.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/core_chromeos_options_handler2.h	View		1 chunk	+0 lines, -59 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/core_chromeos_options_handler2.cc	View		1 chunk	+0 lines, -272 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/cros_language_options_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/cros_language_options_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/cros_language_options_handler2.h	View		1 chunk	+0 lines, -76 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/cros_language_options_handler2.cc	View		1 chunk	+0 lines, -246 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/display_options_handler.h	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/guest_mode_options_ui2_browsertest.cc	View	1 2	1 chunk	+0 lines, -35 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/guest_mode_options_ui_browsertest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/internet_options_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/internet_options_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/internet_options_handler2.h	View		1 chunk	+0 lines, -187 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/internet_options_handler2.cc	View		1 chunk	+0 lines, -1473 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/keyboard_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/keyboard_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/keyboard_handler2.h	View		1 chunk	+0 lines, -32 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/keyboard_handler2.cc	View		1 chunk	+0 lines, -82 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/language_chewing_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/language_chewing_handler.cc	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/language_chewing_handler2.h	View		1 chunk	+0 lines, -37 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/language_chewing_handler2.cc	View		1 chunk	+0 lines, -105 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/language_hangul_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/language_hangul_handler.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/language_hangul_handler2.h	View		1 chunk	+0 lines, -40 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/language_hangul_handler2.cc	View		1 chunk	+0 lines, -49 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/language_mozc_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/language_mozc_handler.cc	View	1 2 3	1 chunk	+3 lines, -3 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/language_mozc_handler2.h	View		1 chunk	+0 lines, -36 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/language_mozc_handler2.cc	View		1 chunk	+0 lines, -72 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/language_options_util.h	View	1 2 3	2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/language_options_util.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/language_options_util2.h	View		1 chunk	+0 lines, -85 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/language_options_util2.cc	View		1 chunk	+0 lines, -20 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/language_pinyin_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/language_pinyin_handler.cc	View	1 2 3	1 chunk	+3 lines, -3 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/language_pinyin_handler2.h	View		1 chunk	+0 lines, -36 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/language_pinyin_handler2.cc	View		1 chunk	+0 lines, -69 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/pointer_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/pointer_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/pointer_handler2.h	View		1 chunk	+0 lines, -47 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/pointer_handler2.cc	View		1 chunk	+0 lines, -82 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/proxy_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/proxy_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/proxy_handler2.h	View		1 chunk	+0 lines, -32 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/proxy_handler2.cc	View		1 chunk	+0 lines, -65 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler2.h	View		1 chunk	+0 lines, -96 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler2.cc	View		1 chunk	+0 lines, -260 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/stats_options_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/stats_options_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/stats_options_handler2.h	View		1 chunk	+0 lines, -39 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/stats_options_handler2.cc	View		1 chunk	+0 lines, -47 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/user_image_source.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/user_image_source.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/user_image_source2.h	View		1 chunk	+0 lines, -48 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/user_image_source2.cc	View		1 chunk	+0 lines, -115 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/wallpaper_source.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/wallpaper_source.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/wallpaper_source2.h	View		1 chunk	+0 lines, -62 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/wallpaper_source2.cc	View		1 chunk	+0 lines, -171 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/wallpaper_thumbnail_source.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/chromeos/wallpaper_thumbnail_source.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/wallpaper_thumbnail_source2.h	View		1 chunk	+0 lines, -48 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/wallpaper_thumbnail_source2.cc	View		1 chunk	+0 lines, -121 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/clear_browser_data_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/clear_browser_data_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/clear_browser_data_handler2.h	View		1 chunk	+0 lines, -49 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/clear_browser_data_handler2.cc	View		1 chunk	+0 lines, -161 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/content_options2_browsertest.js	View	1 2	1 chunk	+0 lines, -24 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/content_options_browsertest.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/content_settings_exception_area2_browsertest.js	View	1 2	1 chunk	+0 lines, -26 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/content_settings_exception_area_browsertest.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/content_settings_handler.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/content_settings_handler.cc	View	1 2 3	2 chunks	+3 lines, -2 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/content_settings_handler2.h	View		1 chunk	+0 lines, -187 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/content_settings_handler2.cc	View		1 chunk	+0 lines, -1337 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/cookies_view2_browsertest.js	View	1 2	1 chunk	+0 lines, -24 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/cookies_view_browsertest.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/cookies_view_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/cookies_view_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/cookies_view_handler2.h	View		1 chunk	+0 lines, -77 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/cookies_view_handler2.cc	View		1 chunk	+0 lines, -242 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/core_options_handler.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/core_options_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/core_options_handler2.h	View		1 chunk	+0 lines, -160 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/core_options_handler2.cc	View		1 chunk	+0 lines, -483 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/font_settings2_browsertest.js	View	1 2	1 chunk	+0 lines, -24 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/font_settings_browsertest.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/font_settings_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/font_settings_handler.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/font_settings_handler2.h	View		1 chunk	+0 lines, -62 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/font_settings_handler2.cc	View		1 chunk	+0 lines, -248 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/font_settings_utils.h	View	1 2 3	2 chunks	+4 lines, -4 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/font_settings_utils2.h	View		1 chunk	+0 lines, -26 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/font_settings_utils2_mac.mm	View		1 chunk	+0 lines, -42 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/font_settings_utils2_win.cc	View	1 2	1 chunk	+0 lines, -14 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/font_settings_utils2_x11.cc	View		1 chunk	+0 lines, -14 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/font_settings_utils_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/browser/ui/webui/options2/font_settings_utils_win.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/font_settings_utils_x11.cc	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/handler_options_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/handler_options_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/handler_options_handler2.h	View		1 chunk	+0 lines, -88 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/handler_options_handler2.cc	View		1 chunk	+0 lines, -210 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/home_page_overlay_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/home_page_overlay_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/home_page_overlay_handler2.h	View		1 chunk	+0 lines, -48 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/home_page_overlay_handler2.cc	View		1 chunk	+0 lines, -62 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/import_data_handler.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/import_data_handler.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/import_data_handler2.h	View		1 chunk	+0 lines, -64 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/import_data_handler2.cc	View	1	1 chunk	+0 lines, -192 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/language_options2_browsertest.js	View	1 2	1 chunk	+0 lines, -24 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/language_options_browsertest.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/language_options_handler.h	View	1 2 3	2 chunks	+5 lines, -5 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/language_options_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/language_options_handler2.h	View		1 chunk	+0 lines, -48 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/language_options_handler2.cc	View		1 chunk	+0 lines, -132 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/language_options_handler2_unittest.cc	View	1 2	1 chunk	+0 lines, -226 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/language_options_handler_common.h	View	1 2 3	2 chunks	+5 lines, -5 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/language_options_handler_common.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/language_options_handler_common2.h	View		1 chunk	+0 lines, -73 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/language_options_handler_common2.cc	View		1 chunk	+0 lines, -169 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/language_options_handler_unittest.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/manage_profile_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/manage_profile_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/manage_profile_handler2.h	View		1 chunk	+0 lines, -82 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/manage_profile_handler2.cc	View		1 chunk	+0 lines, -279 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/media_gallery_handler.h	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/options2_browsertest.js	View	1 2	1 chunk	+0 lines, -106 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/options_browsertest.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/options_ui.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/options_ui.cc	View		3 chunks	+35 lines, -35 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/options_ui2.h	View		1 chunk	+0 lines, -142 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/options_ui2.cc	View		1 chunk	+0 lines, -397 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/options_ui2_browsertest.h	View	1 2	1 chunk	+0 lines, -32 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/options_ui2_browsertest.cc	View	1 2	1 chunk	+0 lines, -51 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/options_ui_browsertest.h	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/options_ui_browsertest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/password_manager2_browsertest.js	View	1 2	1 chunk	+0 lines, -25 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/password_manager_browsertest.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/password_manager_handler.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/password_manager_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/password_manager_handler2.h	View		1 chunk	+0 lines, -139 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/password_manager_handler2.cc	View		1 chunk	+0 lines, -282 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/search_engine_manager2_browsertest.js	View	1 2	1 chunk	+0 lines, -33 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/search_engine_manager_browsertest.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/search_engine_manager_handler.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/search_engine_manager_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/search_engine_manager_handler2.h	View		1 chunk	+0 lines, -86 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/search_engine_manager_handler2.cc	View		1 chunk	+0 lines, -317 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/startup_pages_handler.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/startup_pages_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/startup_pages_handler2.h	View		1 chunk	+0 lines, -102 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/startup_pages_handler2.cc	View		1 chunk	+0 lines, -259 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/web_intents_settings_handler.h	View	1 2 3	2 chunks	+5 lines, -5 lines	0 comments	Download
A +	chrome/browser/ui/webui/options2/web_intents_settings_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/web_intents_settings_handler2.h	View		1 chunk	+0 lines, -81 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/web_intents_settings_handler2.cc	View		1 chunk	+0 lines, -164 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/sync_setup_handler.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/uber/uber_ui.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser_tests.isolate	View	1 2	1 chunk	+10 lines, -10 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4	2 chunks	+86 lines, -86 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4	2 chunks	+15 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

thestig: chrome/chrome_browser.gypi, chrome/browser_tests.isolate, chrome/chrome_tests.gypi, chrome/browser/chromeos/login/user_manager.h sky: chrome/browser/ui/chrome_pages.cc csilv: chrome/browser/ui/webui/ NOTE: No functional changes, just renames ...

8 years, 5 months ago (2012-07-11 00:03:26 UTC) #1

csilv

LGTM w/ green trybots. Copyright date nits aren't required, but nice to have. http://codereview.chromium.org/10698140/diff/7003/chrome/browser/ui/webui/options2/advanced_options_utils.h File ...

8 years, 5 months ago (2012-07-11 00:45:48 UTC) #2

Dan Beam

https://chromiumcodereview.appspot.com/10698140/diff/7003/chrome/browser/ui/webui/options2/advanced_options_utils.h File chrome/browser/ui/webui/options2/advanced_options_utils.h (right): https://chromiumcodereview.appspot.com/10698140/diff/7003/chrome/browser/ui/webui/options2/advanced_options_utils.h#newcode1 chrome/browser/ui/webui/options2/advanced_options_utils.h:1: // Copyright (c) 2011 The Chromium Authors. All rights ...

8 years, 5 months ago (2012-07-11 01:08:35 UTC) #3

TBR'ing sky@ as he's OOO and it's a 1 char change

Expand Messages | Collapse Messages