Write file:// tests for BufferedDataSource and fix some bugs as a result.

Write file:// tests for BufferedDataSource and fix some bugs as a result.

It turns out we had two bugs in our non-HTTP code path:
  1) Connection retries used the wrong start callback, which caused the loader to never get created
  2) The start position for non-HTTP resources is kPositionNotSpecified, which caused us to report [-1, file size) instead of [0, file size) for buffered status

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146035

[scherkus (not reviewing), 2012-07-10 22:18:33]

while I'm not super happy w/ some of the duplicated tests I tried messing around
w/ common base classes, parameterized tests, etc... but it's not a perfect fit
since the responses and buffering expectations are different depending on HTTP
vs non-HTTP

https://chromiumcodereview.appspot.com/10698139/diff/3006/webkit/media/buffer...
File webkit/media/buffered_data_source.cc (right):

https://chromiumcodereview.appspot.com/10698139/diff/3006/webkit/media/buffer...
webkit/media/buffered_data_source.cc:291:
base::Bind(&BufferedDataSource::PartialReadStartCallback, this),
fixes bug #1

https://chromiumcodereview.appspot.com/10698139/diff/3006/webkit/media/buffer...
webkit/media/buffered_data_source.cc:614: host()->AddBufferedByteRange(0,
total_bytes_);
fixes bug #2

[Ami GONE FROM CHROMIUM, 2012-07-11 00:51:54]

I don't like the dup'd tests either, but this is clearly a uniform improvement
over the previous state of the code.

LGTM % nits

https://chromiumcodereview.appspot.com/10698139/diff/3006/webkit/media/buffer...
File webkit/media/buffered_data_source.cc (right):

https://chromiumcodereview.appspot.com/10698139/diff/3006/webkit/media/buffer...
webkit/media/buffered_data_source.cc:610: if (total_bytes_ !=
kPositionNotSpecified) {
reverse test & early-return?

https://chromiumcodereview.appspot.com/10698139/diff/3006/webkit/media/buffer...
File webkit/media/buffered_data_source_unittest.cc (right):

https://chromiumcodereview.appspot.com/10698139/diff/3006/webkit/media/buffer...
webkit/media/buffered_data_source_unittest.cc:117: // Helper to initialize tests
with a valid HTTP 206 response.
no such thing as a non-HTTP 206, so change doesn't seem helpful.  Either way.

https://chromiumcodereview.appspot.com/10698139/diff/3006/webkit/media/buffer...
webkit/media/buffered_data_source_unittest.cc:120:
EXPECT_TRUE(data_source_->downloading());
could move this back to Initialize as EXPECT_EQ(data_source_->downloading(),
is_http);

[scherkus (not reviewing), 2012-07-11 01:10:56]

http://codereview.chromium.org/10698139/diff/3006/webkit/media/buffered_data_...
File webkit/media/buffered_data_source.cc (right):

http://codereview.chromium.org/10698139/diff/3006/webkit/media/buffered_data_...
webkit/media/buffered_data_source.cc:610: if (total_bytes_ !=
kPositionNotSpecified) {
On 2012/07/11 00:51:54, Ami Fischman wrote:
> reverse test & early-return?

Done.

http://codereview.chromium.org/10698139/diff/3006/webkit/media/buffered_data_...
File webkit/media/buffered_data_source_unittest.cc (right):

http://codereview.chromium.org/10698139/diff/3006/webkit/media/buffered_data_...
webkit/media/buffered_data_source_unittest.cc:117: // Helper to initialize tests
with a valid HTTP 206 response.
On 2012/07/11 00:51:54, Ami Fischman wrote:
> no such thing as a non-HTTP 206, so change doesn't seem helpful.  Either way.

Done.

http://codereview.chromium.org/10698139/diff/3006/webkit/media/buffered_data_...
webkit/media/buffered_data_source_unittest.cc:120:
EXPECT_TRUE(data_source_->downloading());
On 2012/07/11 00:51:54, Ami Fischman wrote:
> could move this back to Initialize as EXPECT_EQ(data_source_->downloading(),
> is_http);

I'll do it but duplicating the SchemeIs() code here makes me a little sad

[commit-bot: I haz the power, 2012-07-11 01:24:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/10698139/13001

[commit-bot: I haz the power, 2012-07-11 02:36:03]

Change committed as 146035