Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 10698138: PPAPI/NaCl: Make ipc_channel_nacl post to the correct thread. (Closed)

Created:
8 years, 5 months ago by dmichael (off chromium)
Modified:
8 years, 5 months ago
Reviewers:
bbudge, brettw
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

PPAPI/NaCl: Make ipc_channel_nacl post to the correct thread. Connect is called on the thread where Channel::Send will be invoked (and where messages should be dispatched). But Channel might be _created_ on some other thread. Therefore, we need to post data that we read to the thread on which Connect is called. NOT the thread where the Channel was created. This fixes an issue where sync messages were never getting their replies, because the DidRecvMsg task was being run on the thread where ChannelProxy::Send was called, not the Channel thread (which is the IO thread in this case). BUG=116317 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146006

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M ipc/ipc_channel_nacl.cc View 1 2 chunks +16 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dmichael (off chromium)
Should be quick
8 years, 5 months ago (2012-07-10 21:28:06 UTC) #1
bbudge
lgtm https://chromiumcodereview.appspot.com/10698138/diff/1/ipc/ipc_channel_nacl.cc File ipc/ipc_channel_nacl.cc (right): https://chromiumcodereview.appspot.com/10698138/diff/1/ipc/ipc_channel_nacl.cc#newcode151 ipc/ipc_channel_nacl.cc:151: // is called to decide which MessageLoopProxy to ...
8 years, 5 months ago (2012-07-10 21:31:21 UTC) #2
brettw
lgtm
8 years, 5 months ago (2012-07-10 21:33:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/10698138/3002
8 years, 5 months ago (2012-07-10 21:40:34 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 00:49:18 UTC) #5
Change committed as 146006

Powered by Google App Engine
This is Rietveld 408576698