Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: media/base/pipeline_unittest.cc

Issue 10698134: Merge 143765 - Ensure media's buffered ranges always have a range that includes currentTime. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1180/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/pipeline.cc ('k') | media/base/ranges.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline_unittest.cc
===================================================================
--- media/base/pipeline_unittest.cc (revision 145933)
+++ media/base/pipeline_unittest.cc (working copy)
@@ -480,11 +480,15 @@
EXPECT_EQ(1u, pipeline_->GetBufferedTimeRanges().size());
EXPECT_EQ(base::TimeDelta(), pipeline_->GetBufferedTimeRanges().start(0));
EXPECT_EQ(kDuration / 8, pipeline_->GetBufferedTimeRanges().end(0));
+ pipeline_->AddBufferedTimeRange(base::TimeDelta(), kDuration / 8);
+ EXPECT_EQ(base::TimeDelta(), pipeline_->GetBufferedTimeRanges().start(0));
+ EXPECT_EQ(kDuration / 8, pipeline_->GetBufferedTimeRanges().end(0));
base::TimeDelta kSeekTime = kDuration / 2;
ExpectSeek(kSeekTime);
DoSeek(kSeekTime);
+ EXPECT_TRUE(pipeline_->DidLoadingProgress());
EXPECT_FALSE(pipeline_->DidLoadingProgress());
pipeline_->AddBufferedByteRange(kTotalBytes / 2,
kTotalBytes / 2 + kTotalBytes / 8);
@@ -496,6 +500,15 @@
EXPECT_EQ(kDuration / 2, pipeline_->GetBufferedTimeRanges().start(1));
EXPECT_EQ(kDuration / 2 + kDuration / 8,
pipeline_->GetBufferedTimeRanges().end(1));
+
+ pipeline_->AddBufferedTimeRange(kDuration / 4, 3 * kDuration / 8);
+ EXPECT_EQ(base::TimeDelta(), pipeline_->GetBufferedTimeRanges().start(0));
+ EXPECT_EQ(kDuration / 8, pipeline_->GetBufferedTimeRanges().end(0));
+ EXPECT_EQ(kDuration / 4, pipeline_->GetBufferedTimeRanges().start(1));
+ EXPECT_EQ(3* kDuration / 8, pipeline_->GetBufferedTimeRanges().end(1));
+ EXPECT_EQ(kDuration / 2, pipeline_->GetBufferedTimeRanges().start(2));
+ EXPECT_EQ(kDuration / 2 + kDuration / 8,
+ pipeline_->GetBufferedTimeRanges().end(2));
}
TEST_F(PipelineTest, DisableAudioRenderer) {
« no previous file with comments | « media/base/pipeline.cc ('k') | media/base/ranges.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698