Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 10698128: Improve code for checked instance calls (polymorphic calls) and expand printing of PolymorphicInsta… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_ia32.cc
===================================================================
--- runtime/vm/intermediate_language_ia32.cc (revision 9512)
+++ runtime/vm/intermediate_language_ia32.cc (working copy)
@@ -668,17 +668,16 @@
__ movl(EAX, Address(ESP, (kNumArguments - 1) * kWordSize));
__ testl(EAX, Immediate(kSmiTagMask));
__ j(ZERO, deopt);
- Label done;
__ LoadClassId(EDI, EAX);
compiler->EmitTestAndCall(ic_data,
EDI, // Class id register.
kNumArguments,
Array::Handle(), // No named arguments.
- deopt, &done, // Labels.
+ deopt, // Deoptimize target.
+ NULL, // Fallthrough when done.
comp->cid(),
comp->token_pos(),
comp->try_index());
- __ Bind(&done);
}
@@ -807,17 +806,16 @@
__ movl(EAX, Address(ESP, (kNumArguments - 1) * kWordSize));
__ testl(EAX, Immediate(kSmiTagMask));
__ j(ZERO, deopt);
- Label done;
__ LoadClassId(EDI, EAX);
compiler->EmitTestAndCall(ic_data,
EDI, // Class id register.
kNumArguments,
Array::Handle(), // No named arguments.
- deopt, &done, // Labels.
+ deopt, // Deoptimize target.
+ NULL, // Fallthrough when done.
comp->cid(),
comp->token_pos(),
comp->try_index());
- __ Bind(&done);
}
@@ -1958,7 +1956,8 @@
EDI, // Class id register.
instance_call()->ArgumentCount(),
instance_call()->argument_names(),
- deopt, &done, // Labels.
+ deopt,
+ (is_smi_label == &handle_smi) ? &done : NULL,
instance_call()->cid(),
instance_call()->token_pos(),
instance_call()->try_index());

Powered by Google App Engine
This is Rietveld 408576698