Issue 10698125: Fixed array bounds check elimination (Chromium issue 132114).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10698125: Fixed array bounds check elimination (Chromium issue 132114). (Closed)

Created:
8 years, 5 months ago by Massi

Modified:
8 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Google), Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fixed array bounds check elimination (Chromium issue 132114). BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12025

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -52 lines)			Patch
M	src/flag-definitions.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen.cc	View	6 chunks	+64 lines, -50 lines	0 comments	Download
M	test/mjsunit/array-bounds-check-removal.js	View	2 chunks	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

8 years, 5 months ago (2012-07-10 10:57:31 UTC) #2

LGTM

But I think implementation could become _much_ cleaner if we had a 

BoundsCheckRange index, low, high, length

(where low and high are int32_t [not even HConstant] and index and length are
HValues.

Bounds check elimination if performed after GVN so there is absolutely no gain
in exposing additions on HIR level.

Expand Messages | Collapse Messages