gdata: Remove sub_dir_type from CacheEntry for simplicity

gdata: Remove sub_dir_type from CacheEntry for simplicity

Having this member was awkward, as it's inconsistent
with other states, which are all stored in |cache_state|.

BUG=136390
TEST=out/Release/unit_tests --gtest_filter=GData*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145933

[hshi1, 2012-07-10 17:41:59]

LGTM with nits, thanks!

http://codereview.chromium.org/10698124/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_cache.h (right):

http://codereview.chromium.org/10698124/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_cache.h:88: CACHE_STATE_PERSISTENT = 0x1 <<
4,
Nit: Let's make the spacing consistent. Either vertically line up at the "=" or
just remove the multiple spaces (I vote for line up).

http://codereview.chromium.org/10698124/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_cache.h:136: bool IsPersistent() const  {
return IsCachePersistent(cache_state); }
Nit: Let's remove the double spaces between "const" and "{ return ...". Sorry I
introduced this inconsistency in IsMounted().

[satorux1, 2012-07-10 18:26:12]

http://codereview.chromium.org/10698124/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_cache.h (right):

http://codereview.chromium.org/10698124/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_cache.h:88: CACHE_STATE_PERSISTENT = 0x1 <<
4,
On 2012/07/10 17:41:59, hshi1 wrote:
> Nit: Let's make the spacing consistent. Either vertically line up at the "="
or
> just remove the multiple spaces (I vote for line up).

Done.

http://codereview.chromium.org/10698124/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_cache.h:136: bool IsPersistent() const  {
return IsCachePersistent(cache_state); }
On 2012/07/10 17:41:59, hshi1 wrote:
> Nit: Let's remove the double spaces between "const" and "{ return ...". Sorry
I
> introduced this inconsistency in IsMounted().

Done.

[hshi1, 2012-07-10 18:31:56]

lgtm