chrome/browser/resources/chromeos/wallpaper_manager/main.html - Issue 10698099: Implement the new wallpaper manager launcher window.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/chromeos/wallpaper_manager/main.html

Issue 10698099: Implement the new wallpaper manager launcher window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Nits Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/resources/chromeos/wallpaper_manager/js/main.js ('K') | « chrome/browser/resources/chromeos/wallpaper_manager/js/mock_chrome.js ('k') | chrome/browser/resources/chromeos/wallpaper_manager/manifest.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <html i18n-values="dir:textdirection;">

3 <!--	2 <!--

4 ------	3 ------

5 Copyright (c) 2012 The Chromium Authors. All rights reserved.	4 Copyright (c) 2012 The Chromium Authors. All rights reserved.

6 Use of this source code is governed by a BSD-style license that can be	5 Use of this source code is governed by a BSD-style license that can be

7 found in the LICENSE file.	6 found in the LICENSE file.

8

9 -->	7 -->

	8 <html i18n-values="dir:textdirection;">

10 <head>	9 <head>

11 <title>Placeholder for Wallpaper Manager Main page</title>	10 <title>Placeholder for Wallpaper Manager Main page</title>

	11 <script src="js/main_scripts.js"></script>

	12 <if expr="0">

	13 <!-- This file has not been flattened, load individual scripts.

	14 Keep the list in sync with js/main_scripts.js. -->
	flackr 2012/07/04 22:20:57 Do you know why file manager was written this way? Do you know why file manager was written this way? I still think you should just include all your javascript here and then things would be simpler. bshe 2012/07/05 13:54:50 The main_scripts was introduced in this CL: http:/ The main_scripts was introduced in this CL: http://codereview.chromium.org/10068007/ It seems to relate to file manager's content security policy at that time. However, after a quick test with wallpaper manager. I found that even with "default-src:none" setting (I am guessing it means inline scripts are disallowed), just using <script> tag for script files also work. These scripts are not inlined to html after flatten. Another perspective is using main_scripts can avoid to keep the list sync with chrome/browser/resources/component_extension_resources.grd file. So in the grd file, only main_scripts.js needed to be added. So we either keep the list sync with grd file or with main_scripts file. But using main_scripts may have a faster loading time since we only have to load one file? On 2012/07/04 22:20:57, flackr wrote: Show quoted text > Do you know why file manager was written this way? I still think you should just > include all your javascript here and then things would be simpler.
	15 <script src="js/main.js"></script>

	16 </if>

12 </head>	17 </head>

13 <body>	18 <body>

14 <h1>Wallpaper Manager</h1>	19 <h1>Wallpaper Manager</h1>

15 <p>Coming soon.</p>	20 <p>Coming soon.</p>

16 </body>	21 </body>

17 </html>	22 </html>

OLD	NEW