Add dummy implementation of about_flags for Android.

Add dummy implementation of about_flags for Android.

This is part of the unit_tests linking effort.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146249

[Nico, 2012-07-04 11:39:32]

lgtm

https://chromiumcodereview.appspot.com/10698095/diff/2001/chrome/browser/abou...
File chrome/browser/about_flags_android.cc (right):

https://chromiumcodereview.appspot.com/10698095/diff/2001/chrome/browser/abou...
chrome/browser/about_flags_android.cc:14: NOTIMPLEMENTED();
Do you intend to implement these eventually? If not, the NOTIMPLEMENTED()s will
cause logspam forever (since these functions are getting called). So maybe
remove the NOTIMPLEMENTED()s.

[Philippe, 2012-07-04 11:45:38]

Thanks Nico for the quick review!

https://chromiumcodereview.appspot.com/10698095/diff/2001/chrome/browser/abou...
File chrome/browser/about_flags_android.cc (right):

https://chromiumcodereview.appspot.com/10698095/diff/2001/chrome/browser/abou...
chrome/browser/about_flags_android.cc:14: NOTIMPLEMENTED();
On 2012/07/04 11:39:32, Nico wrote:
> Do you intend to implement these eventually? If not, the NOTIMPLEMENTED()s
will
> cause logspam forever (since these functions are getting called). So maybe
> remove the NOTIMPLEMENTED()s.

Indeed. I don't think we plan to implement that eventually. I removed the
NOTIMPLEMENTED()s.

[Yaron, 2012-07-10 05:44:51]

lgtm

[commit-bot: I haz the power, 2012-07-10 09:17:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pliard@chromium.org/10698095/2002

[commit-bot: I haz the power, 2012-07-10 09:17:12]

Presubmit check for 10698095-2002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/sync

[Philippe, 2012-07-10 09:37:18]

On 2012/07/10 09:17:12, I haz the power (commit-bot) wrote:
> Presubmit check for 10698095-2002 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit Messages **
> If this change has an associated bug, add BUG=[bug number].
> 
> If this change requires manual test instructions to QA team, add
> TEST=[instructions].
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for files in these directories:
>     chrome/browser/sync

I need your approval Lingesh :)

[Philippe, 2012-07-11 14:14:41]

On 2012/07/10 09:37:18, Philippe wrote:
> On 2012/07/10 09:17:12, I haz the power (commit-bot) wrote:
> > Presubmit check for 10698095-2002 failed and returned exit status 1.
> > 
> > Running presubmit commit checks ...
> > 
> > ** Presubmit Messages **
> > If this change has an associated bug, add BUG=[bug number].
> > 
> > If this change requires manual test instructions to QA team, add
> > TEST=[instructions].
> > 
> > ** Presubmit ERRORS **
> > Missing LGTM from an OWNER for files in these directories:
> >     chrome/browser/sync
> 
> I need your approval Lingesh :)

Richard, could you please review the changes in chrome/browser/sync/? Lingesh
does not seem to be available.

[rlarocque, 2012-07-11 17:37:11]

On 2012/07/11 14:14:41, Philippe wrote:
> On 2012/07/10 09:37:18, Philippe wrote:
> > On 2012/07/10 09:17:12, I haz the power (commit-bot) wrote:
> > > Presubmit check for 10698095-2002 failed and returned exit status 1.
> > > 
> > > Running presubmit commit checks ...
> > > 
> > > ** Presubmit Messages **
> > > If this change has an associated bug, add BUG=[bug number].
> > > 
> > > If this change requires manual test instructions to QA team, add
> > > TEST=[instructions].
> > > 
> > > ** Presubmit ERRORS **
> > > Missing LGTM from an OWNER for files in these directories:
> > >     chrome/browser/sync
> > 
> > I need your approval Lingesh :)
> 
> Richard, could you please review the changes in chrome/browser/sync/? Lingesh
> does not seem to be available.

LGTM.

[commit-bot: I haz the power, 2012-07-11 21:35:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pliard@chromium.org/10698095/2002

[commit-bot: I haz the power, 2012-07-12 00:28:11]

Change committed as 146249