The previous fix r145315 seems to have broken python 2.6.2 on Windows users.

The previous fix r145315 seems to have broken python 2.6.2 on Windows users.

Since open() and codecs.open() have different behavior, and codecs.open()
misbehaves on python 2.6, switch to open() with manual str decoding.

TBR=cmp@chromium.org
BUG=
TEST=I failed to reproduce, it's a shot in the dark


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145396

[commit-bot: I haz the power, 2012-07-03 23:03:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/10698089/1

[commit-bot: I haz the power, 2012-07-03 23:06:25]

Change committed as 145396

[Munjal (Google), 2012-07-09 19:30:34]

Thanks for fixing this quickly.

[cmp, 2012-07-10 01:27:01]

lgtm with nit

probably entering decode()-land may help to add a test somewhere to verify the
right thing happens to convert a unicode string into a utf-8 string.

https://chromiumcodereview.appspot.com/10698089/diff/1/gclient_utils.py
File gclient_utils.py (right):

https://chromiumcodereview.appspot.com/10698089/diff/1/gclient_utils.py#newco...
gclient_utils.py:81: # codecs.open() has different behavior than open() on
python 2.6.
since you're no longer calling codecs.open(), this comment seems misplaced.  my
assumption is that the comment was about the 'replace' call in the previous CL,
and that it's no longer relevant?