Issue 10698086: Add the opennewwindow verb to the list of verbs created with a DelegateExecute handler under the Me…

Issue 10698086: Add the opennewwindow verb to the list of verbs created with a DelegateExecute handler under the Me… (Closed)

Created:
8 years, 5 months ago by ananta

Modified:
8 years, 5 months ago

Reviewers:
gab

CC:
chromium-reviews, grt+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add the opennewwindow verb to the list of verbs created with a DelegateExecute handler under the Metro Chrome HKCR\<Chrome>/Chromium key. This is needed for the opennewwindow operation on the chrome metro tile to work correctly. This fix only ensures that metro chrome launches when we select the open new window operation on the metro tile. Other fixes are needed to ensure that subsequent open new window operations cause new tabs to get created. BUG=135122 R=gab Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145383

Patch Set 1 #

Total comments: 7

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/installer/util/shell_util.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/installer/util/shell_util.cc	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

gab

lgtm (with nit below). https://chromiumcodereview.appspot.com/10698086/diff/1/chrome/installer/util/shell_util.cc File chrome/installer/util/shell_util.cc (right): https://chromiumcodereview.appspot.com/10698086/diff/1/chrome/installer/util/shell_util.cc#newcode162 chrome/installer/util/shell_util.cc:162: ShellUtil::kRegVerbOpenNewWindow}; here as well. https://chromiumcodereview.appspot.com/10698086/diff/1/chrome/installer/util/shell_util.cc#newcode842 ...

8 years, 5 months ago (2012-07-03 21:03:41 UTC) #2

gab

Another nit (sorry just saw it). https://chromiumcodereview.appspot.com/10698086/diff/1/chrome/installer/util/shell_util.cc File chrome/installer/util/shell_util.cc (right): https://chromiumcodereview.appspot.com/10698086/diff/1/chrome/installer/util/shell_util.cc#newcode162 chrome/installer/util/shell_util.cc:162: ShellUtil::kRegVerbOpenNewWindow}; nit: Add ...

8 years, 5 months ago (2012-07-03 21:06:34 UTC) #3

ananta

8 years, 5 months ago (2012-07-03 21:06:46 UTC) #4

https://chromiumcodereview.appspot.com/10698086/diff/1/chrome/installer/util/...
File chrome/installer/util/shell_util.cc (right):

https://chromiumcodereview.appspot.com/10698086/diff/1/chrome/installer/util/...
chrome/installer/util/shell_util.cc:162: ShellUtil::kRegVerbOpenNewWindow};
On 2012/07/03 21:03:41, gab wrote:
> here as well.

Done.

https://chromiumcodereview.appspot.com/10698086/diff/1/chrome/installer/util/...
chrome/installer/util/shell_util.cc:842: const wchar_t*
ShellUtil::kRegVerbOpenNewWindow = L"opennewwindow";
On 2012/07/03 21:03:41, gab wrote:
> and here too.

Done.

https://chromiumcodereview.appspot.com/10698086/diff/1/chrome/installer/util/...
File chrome/installer/util/shell_util.h (right):

https://chromiumcodereview.appspot.com/10698086/diff/1/chrome/installer/util/...
chrome/installer/util/shell_util.h:120: static const wchar_t*
kRegVerbOpenNewWindow;
On 2012/07/03 21:03:41, gab wrote:
> nit: Can you order verbs in alphabetical order?

Done.

Expand Messages | Collapse Messages