Issue 10698069: Add test case for typed arrays slicing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10698069: Add test case for typed arrays slicing (Closed)

Created:
8 years, 5 months ago by danno

Modified:
8 years, 5 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add test case for typed arrays slicing R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11962

Patch Set 1 #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -33 lines)			Patch
	A +	test/mjsunit/typed-array-slice.js	View		1 chunk	+24 lines, -33 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rossberg

8 years, 5 months ago (2012-07-02 10:40:21 UTC) #2

LGTM, with some nits.

https://chromiumcodereview.appspot.com/10698069/diff/1/test/mjsunit/typed-arr...
File test/mjsunit/typed-array-slice.js (right):

https://chromiumcodereview.appspot.com/10698069/diff/1/test/mjsunit/typed-arr...
test/mjsunit/typed-array-slice.js:38: results4 = [1, 1, 1, 1, 1, 1, 1, 1, 1, 1];
Could you declare all the above variables with 'var'?

https://chromiumcodereview.appspot.com/10698069/diff/1/test/mjsunit/typed-arr...
test/mjsunit/typed-array-slice.js:49: for (i = 0; i < kElementCount; ++i ) {
This could take a 'var', too.

Expand Messages | Collapse Messages