Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 10698032: Fix lazy parsing heuristics to respect outer scope. (Closed)

Created:
8 years, 5 months ago by Michael Starzinger
Modified:
8 years, 5 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Fix lazy parsing heuristics to respect outer scope. This makes sure that a function literal is only parsed lazily when the outer scope actually allows lazy compilation. Otherwise compilation will crash due to a missing function body. R=ulan@chromium.org BUG=chromium:135008 TEST=mjsunit/regress/regress-crbug-135008 Committed: https://code.google.com/p/v8/source/detail?r=11945

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M src/parser.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-135008.js View 1 chunk +15 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
8 years, 5 months ago (2012-06-28 14:52:34 UTC) #1
ulan
8 years, 5 months ago (2012-06-28 14:54:18 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698