Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 10698031: Revert the change adding CompilationHandleScope. (Closed)

Created:
8 years, 5 months ago by sanjoy
Modified:
8 years, 5 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Revert 11939 'Add a CompilationHandleScope' since it breaks array-sort.js in Win32 Release. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11943

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -238 lines) Patch
M src/api.h View 6 chunks +1 line, -35 lines 0 comments Download
M src/api.cc View 3 chunks +1 line, -94 lines 0 comments Download
M src/compiler.h View 4 chunks +0 lines, -26 lines 0 comments Download
M src/compiler.cc View 3 chunks +3 lines, -11 lines 0 comments Download
M src/handles.h View 2 chunks +0 lines, -30 lines 0 comments Download
M src/handles.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sanjoy
8 years, 5 months ago (2012-06-28 12:18:50 UTC) #1
Yang
8 years, 5 months ago (2012-06-28 12:32:34 UTC) #2
On 2012/06/28 12:18:50, sanjoy wrote:

LGTM.

Powered by Google App Engine
This is Rietveld 408576698