Chromium Code Reviews
Help | Chromium Project | Sign in
(446)

Issue 10698023: Get ninja working for nacl. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by bradn
Modified:
1 year, 9 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Get ninja working for nacl.

- Add support for .asm files for win32
- Add support for msvs_target_platform
- Update x64 test to actually do something meaningful relative to how we
use configurations.

BUG=None
TEST=None
R=scottmg@chromium.org
Committed: https://code.google.com/p/gyp/source/detail?r=1422

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -32 lines) Lint Patch
M PRESUBMIT.py View 1 2 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
M pylib/gyp/generator/ninja.py View 1 9 chunks +26 lines, -11 lines 0 comments 0 errors Download
M pylib/gyp/msvs_emulation.py View 1 12 chunks +42 lines, -8 lines 0 comments 0 errors Download
M pylib/gyp/win_tool.py View 1 chunk +17 lines, -0 lines 0 comments 0 errors Download
M test/configurations/x64/configurations.gyp View 1 chunk +12 lines, -0 lines 0 comments 0 errors Download
M test/configurations/x64/gyptest-x86.py View 1 2 2 chunks +15 lines, -13 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 4
bradn
There's one issue with this (thing marked BOGUS). I'll come chat in person.
1 year, 9 months ago #1
scottmg
cool, looks good with fix for BOGUS http://codereview.chromium.org/10698023/diff/1/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py (right): http://codereview.chromium.org/10698023/diff/1/pylib/gyp/generator/ninja.py#newcode756 pylib/gyp/generator/ninja.py:756: # Asm ...
1 year, 9 months ago #2
bradn
PTAL, got the PlatformName working http://codereview.chromium.org/10698023/diff/1/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py (right): http://codereview.chromium.org/10698023/diff/1/pylib/gyp/generator/ninja.py#newcode756 pylib/gyp/generator/ninja.py:756: # Asm files only ...
1 year, 9 months ago #3
scottmg
1 year, 9 months ago #4
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6