[Sync] Rename csync namespace to syncer

[Sync] Rename csync namespace to syncer

Everyone was confused by 'csync'. 'syncer' seems more understandable.

(Note that we can't use the 'sync' namespace since sync() is a function
from unistd.h.)

BUG=10662035
TEST=
TBR=jhawkins@chromium.org,pkasting@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144820

[akalin, 2012-06-27 21:00:30]

+rlarocque for review

This CL was almost entirely automated.  I used sed for csync -> syncer but fixed
the newly-generated long lines manually.

I plan to TBR owners.

[Ilya Sherman, 2012-06-27 21:07:08]

FWIW, "syncer" strikes me as about equally confusing w/ "csync", but has the
disadvantage that it's 1 character longer.  If you're willing to tag on yet
another character, though, I think "syncapi" might be a clear name that has no
conflicts.

[tim (not reviewing), 2012-06-27 21:08:33]

syncapi does have conflicts.  We have sync/api and sync/internal_api, and
then "everything else in sync".


On Wed, Jun 27, 2012 at 2:07 PM, <isherman@chromium.org> wrote:

> FWIW, "syncer" strikes me as about equally confusing w/ "csync", but has
> the
> disadvantage that it's 1 character longer.  If you're willing to tag on yet
> another character, though, I think "syncapi" might be a clear name that
> has no
> conflicts.
>
>
https://chromiumcodereview.**appspot.com/10698014/<https://chromiumcodereview...
>

[Ilya Sherman, 2012-06-27 21:10:51]

On 2012/06/27 21:08:33, timsteele wrote:
> syncapi does have conflicts.  We have sync/api and sync/internal_api, and
> then "everything else in sync".

Ok.  I have no clever suggestions then :/

> 
> 
> On Wed, Jun 27, 2012 at 2:07 PM, <mailto:isherman@chromium.org> wrote:
> 
> > FWIW, "syncer" strikes me as about equally confusing w/ "csync", but has
> > the
> > disadvantage that it's 1 character longer.  If you're willing to tag on yet
> > another character, though, I think "syncapi" might be a clear name that
> > has no
> > conflicts.
> >
> >
>
https://chromiumcodereview.**appspot.com/10698014/%3Chttps://chromiumcoderevi...>
> >

[rlarocque, 2012-06-28 00:00:50]

Part 1:

Congratulations, you broke the code review site!  It won't let me download the
raw diff because the change is too big.

I've found two suspicious-looking diffs comments so far.  The issue may have
originated in one of your previous namespace refactorings.  Could you run your
diff through a regex and look for modifications to comment lines?  There may be
more accidental renames.

http://codereview.chromium.org/10698014/diff/1/chrome/browser/sync/DEPS
File chrome/browser/sync/DEPS (right):

http://codereview.chromium.org/10698014/diff/1/chrome/browser/sync/DEPS#newco...
chrome/browser/sync/DEPS:11: # Used by autofill tests, which should use syncer
instead.
?

http://codereview.chromium.org/10698014/diff/1/chrome/browser/sync/glue/sync_...
File chrome/browser/sync/glue/sync_backend_host.cc (right):

http://codereview.chromium.org/10698014/diff/1/chrome/browser/sync/glue/sync_...
chrome/browser/sync/glue/sync_backend_host.cc:391: syncer::ModelSafeRoutingInfo
routing_info;
Bad indent?  Now might be a good time to fix it.

http://codereview.chromium.org/10698014/diff/1/chrome/browser/sync/glue/typed...
File chrome/browser/sync/glue/typed_url_change_processor.h (right):

http://codereview.chromium.org/10698014/diff/1/chrome/browser/sync/glue/typed...
chrome/browser/sync/glue/typed_url_change_processor.h:42: // applying them to
the syncer 'syncable' model, and vice versa. All
There are some strange comments in this file.  Is 'csync model' or 'syncer
model' a thing?

[rlarocque, 2012-06-28 00:27:56]

Part 2 of 2:

I found a few more nits.  Maybe you could grep for files that contain 'namespace
syncer {' but not a corresponding '} // namespace syncer'?  There would be many
false positives, but it might detect a few legitimate bugs.

http://codereview.chromium.org/10698014/diff/1/sync/notifier/notifications_di...
File sync/notifier/notifications_disabled_reason.cc (right):

http://codereview.chromium.org/10698014/diff/1/sync/notifier/notifications_di...
sync/notifier/notifications_disabled_reason.cc:9: namespace syncer {
I think the comment on the matching brace needs to be updated.

http://codereview.chromium.org/10698014/diff/1/sync/notifier/registration_man...
File sync/notifier/registration_manager_unittest.cc (right):

http://codereview.chromium.org/10698014/diff/1/sync/notifier/registration_man...
sync/notifier/registration_manager_unittest.cc:20: namespace syncer {
Check the close brace comment on this one, too.

http://codereview.chromium.org/10698014/diff/1/sync/notifier/state_writer.h
File sync/notifier/state_writer.h (right):

http://codereview.chromium.org/10698014/diff/1/sync/notifier/state_writer.h#n...
sync/notifier/state_writer.h:13: namespace syncer {
close brace comment.

http://codereview.chromium.org/10698014/diff/1/sync/protocol/proto_enum_conve...
File sync/protocol/proto_enum_conversions.cc (right):

http://codereview.chromium.org/10698014/diff/1/sync/protocol/proto_enum_conve...
sync/protocol/proto_enum_conversions.cc:12: namespace syncer {
See matching brace's comment.

[akalin, 2012-06-28 20:33:57]

On 2012/06/28 00:00:50, rlarocque wrote:
> Part 1:
> 
> Congratulations, you broke the code review site!  It won't let me download the
> raw diff because the change is too big.
> 
> I've found two suspicious-looking diffs comments so far.  The issue may have
> originated in one of your previous namespace refactorings.  Could you run your
> diff through a regex and look for modifications to comment lines?  There may
be
> more accidental renames.
> 
> http://codereview.chromium.org/10698014/diff/1/chrome/browser/sync/DEPS
> File chrome/browser/sync/DEPS (right):
> 
>
http://codereview.chromium.org/10698014/diff/1/chrome/browser/sync/DEPS#newco...
> chrome/browser/sync/DEPS:11: # Used by autofill tests, which should use syncer
> instead.
> ?
> 
>
http://codereview.chromium.org/10698014/diff/1/chrome/browser/sync/glue/sync_...
> File chrome/browser/sync/glue/sync_backend_host.cc (right):
> 
>
http://codereview.chromium.org/10698014/diff/1/chrome/browser/sync/glue/sync_...
> chrome/browser/sync/glue/sync_backend_host.cc:391:
syncer::ModelSafeRoutingInfo
> routing_info;
> Bad indent?  Now might be a good time to fix it.

Done.

> 
>
http://codereview.chromium.org/10698014/diff/1/chrome/browser/sync/glue/typed...
> File chrome/browser/sync/glue/typed_url_change_processor.h (right):
> 
>
http://codereview.chromium.org/10698014/diff/1/chrome/browser/sync/glue/typed...
> chrome/browser/sync/glue/typed_url_change_processor.h:42: // applying them to
> the syncer 'syncable' model, and vice versa. All
> There are some strange comments in this file.  Is 'csync model' or 'syncer
> model' a thing?

It looks like those words were originally 'sync_api', which got converted to
'csync' and then 'syncer'.  I went through my sync_api -> csync patch and looked
for comment lines that got inadvertently changed.  I think I fixed all of them.

[akalin, 2012-06-28 20:34:32]

On 2012/06/28 00:27:56, rlarocque wrote:
> Part 2 of 2:
> 
> I found a few more nits.  Maybe you could grep for files that contain
'namespace
> syncer {' but not a corresponding '} // namespace syncer'?  There would be
many
> false positives, but it might detect a few legitimate bugs.
> 
>
http://codereview.chromium.org/10698014/diff/1/sync/notifier/notifications_di...
> File sync/notifier/notifications_disabled_reason.cc (right):
> 
>
http://codereview.chromium.org/10698014/diff/1/sync/notifier/notifications_di...
> sync/notifier/notifications_disabled_reason.cc:9: namespace syncer {
> I think the comment on the matching brace needs to be updated.
> 
>
http://codereview.chromium.org/10698014/diff/1/sync/notifier/registration_man...
> File sync/notifier/registration_manager_unittest.cc (right):
> 
>
http://codereview.chromium.org/10698014/diff/1/sync/notifier/registration_man...
> sync/notifier/registration_manager_unittest.cc:20: namespace syncer {
> Check the close brace comment on this one, too.
> 
> http://codereview.chromium.org/10698014/diff/1/sync/notifier/state_writer.h
> File sync/notifier/state_writer.h (right):
> 
>
http://codereview.chromium.org/10698014/diff/1/sync/notifier/state_writer.h#n...
> sync/notifier/state_writer.h:13: namespace syncer {
> close brace comment.
> 
>
http://codereview.chromium.org/10698014/diff/1/sync/protocol/proto_enum_conve...
> File sync/protocol/proto_enum_conversions.cc (right):
> 
>
http://codereview.chromium.org/10698014/diff/1/sync/protocol/proto_enum_conve...
> sync/protocol/proto_enum_conversions.cc:12: namespace syncer {
> See matching brace's comment.

I grepped and I think I got them all.

I also fixed some instances of having only one space before the comment (instead
of two, as required).

PTAL!

[rlarocque, 2012-06-28 22:19:37]

On 2012/06/28 20:34:32, akalin wrote:
> On 2012/06/28 00:27:56, rlarocque wrote:
> > Part 2 of 2:
> > 
> > I found a few more nits.  Maybe you could grep for files that contain
> 'namespace
> > syncer {' but not a corresponding '} // namespace syncer'?  There would be
> many
> > false positives, but it might detect a few legitimate bugs.
> > 
> >
>
http://codereview.chromium.org/10698014/diff/1/sync/notifier/notifications_di...
> > File sync/notifier/notifications_disabled_reason.cc (right):
> > 
> >
>
http://codereview.chromium.org/10698014/diff/1/sync/notifier/notifications_di...
> > sync/notifier/notifications_disabled_reason.cc:9: namespace syncer {
> > I think the comment on the matching brace needs to be updated.
> > 
> >
>
http://codereview.chromium.org/10698014/diff/1/sync/notifier/registration_man...
> > File sync/notifier/registration_manager_unittest.cc (right):
> > 
> >
>
http://codereview.chromium.org/10698014/diff/1/sync/notifier/registration_man...
> > sync/notifier/registration_manager_unittest.cc:20: namespace syncer {
> > Check the close brace comment on this one, too.
> > 
> > http://codereview.chromium.org/10698014/diff/1/sync/notifier/state_writer.h
> > File sync/notifier/state_writer.h (right):
> > 
> >
>
http://codereview.chromium.org/10698014/diff/1/sync/notifier/state_writer.h#n...
> > sync/notifier/state_writer.h:13: namespace syncer {
> > close brace comment.
> > 
> >
>
http://codereview.chromium.org/10698014/diff/1/sync/protocol/proto_enum_conve...
> > File sync/protocol/proto_enum_conversions.cc (right):
> > 
> >
>
http://codereview.chromium.org/10698014/diff/1/sync/protocol/proto_enum_conve...
> > sync/protocol/proto_enum_conversions.cc:12: namespace syncer {
> > See matching brace's comment.
> 
> I grepped and I think I got them all.
> 
> I also fixed some instances of having only one space before the comment
(instead
> of two, as required).
> 
> PTAL!

LGTM

[akalin, 2012-06-28 23:58:16]

This CL has the wrong bug: should be 128060

On 2012/06/28 22:19:37, rlarocque wrote:
> On 2012/06/28 20:34:32, akalin wrote:
> > On 2012/06/28 00:27:56, rlarocque wrote:
> > > Part 2 of 2:
> > > 
> > > I found a few more nits.  Maybe you could grep for files that contain
> > 'namespace
> > > syncer {' but not a corresponding '} // namespace syncer'?  There would be
> > many
> > > false positives, but it might detect a few legitimate bugs.
> > > 
> > >
> >
>
http://codereview.chromium.org/10698014/diff/1/sync/notifier/notifications_di...
> > > File sync/notifier/notifications_disabled_reason.cc (right):
> > > 
> > >
> >
>
http://codereview.chromium.org/10698014/diff/1/sync/notifier/notifications_di...
> > > sync/notifier/notifications_disabled_reason.cc:9: namespace syncer {
> > > I think the comment on the matching brace needs to be updated.
> > > 
> > >
> >
>
http://codereview.chromium.org/10698014/diff/1/sync/notifier/registration_man...
> > > File sync/notifier/registration_manager_unittest.cc (right):
> > > 
> > >
> >
>
http://codereview.chromium.org/10698014/diff/1/sync/notifier/registration_man...
> > > sync/notifier/registration_manager_unittest.cc:20: namespace syncer {
> > > Check the close brace comment on this one, too.
> > > 
> > >
http://codereview.chromium.org/10698014/diff/1/sync/notifier/state_writer.h
> > > File sync/notifier/state_writer.h (right):
> > > 
> > >
> >
>
http://codereview.chromium.org/10698014/diff/1/sync/notifier/state_writer.h#n...
> > > sync/notifier/state_writer.h:13: namespace syncer {
> > > close brace comment.
> > > 
> > >
> >
>
http://codereview.chromium.org/10698014/diff/1/sync/protocol/proto_enum_conve...
> > > File sync/protocol/proto_enum_conversions.cc (right):
> > > 
> > >
> >
>
http://codereview.chromium.org/10698014/diff/1/sync/protocol/proto_enum_conve...
> > > sync/protocol/proto_enum_conversions.cc:12: namespace syncer {
> > > See matching brace's comment.
> > 
> > I grepped and I think I got them all.
> > 
> > I also fixed some instances of having only one space before the comment
> (instead
> > of two, as required).
> > 
> > PTAL!
> 
> LGTM