Issue 10697094: Add a second kind of HandleScope that ties the lifetime of Handles created in its scope to the life…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10697094: Add a second kind of HandleScope that ties the lifetime of Handles created in its scope to the life… (Closed)

Created:
8 years, 5 months ago by sanjoy

Modified:
8 years, 5 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add a second kind of HandleScope that ties the lifetime of Handles created in its scope to the lifetime of a given CompilationInfo. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11998

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+238 lines, -5 lines)			Patch
M	src/api.h	View	6 chunks	+35 lines, -1 line	0 comments	Download
M	src/api.cc	View	3 chunks	+94 lines, -1 line	0 comments	Download
M	src/compiler.h	View	4 chunks	+26 lines, -0 lines	0 comments	Download
M	src/compiler.cc	View	3 chunks	+11 lines, -3 lines	0 comments	Download
M	src/handles.h	View	2 chunks	+30 lines, -0 lines	0 comments	Download
M	src/handles.cc	View	1 chunk	+41 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 5 months ago (2012-07-06 09:29:19 UTC) #2

LGTM (rubber-stamped, since it just relands a previous CL).

Expand Messages | Collapse Messages