Remove content->app dependency in template_url_prepopulate_data.cc.

Remove content->app dependency in template_url_prepopulate_data.cc.

This is part of Chrome for Android upstreaming and is needed to link
unit_tests successfully.

GetCurrentCountryID() on Android was calling
TemplateURLPrepopulateData::GetCountryCodeAtInstall() which is implemented
internally on the app side.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145539

[felipeg, 2012-07-05 13:27:28]

lgtm

[bulach, 2012-07-05 13:37:40]

lgtm for the android side, but owners need to approve :)
thanks!

[SteveT, 2012-07-05 13:38:28]

OWNERS lgtm with a nit/question inline.

https://chromiumcodereview.appspot.com/10697087/diff/1/chrome/browser/search_...
File chrome/browser/search_engines/template_url_prepopulate_data.cc (right):

https://chromiumcodereview.appspot.com/10697087/diff/1/chrome/browser/search_...
chrome/browser/search_engines/template_url_prepopulate_data.cc:3454: LOG(ERROR)
<< "Invalid country code: " << country_code;
nit: Can we DVLOG instead? Or is this useful in release builds?

[Philippe, 2012-07-05 14:27:40]

Thanks.

https://chromiumcodereview.appspot.com/10697087/diff/1/chrome/browser/search_...
File chrome/browser/search_engines/template_url_prepopulate_data.cc (right):

https://chromiumcodereview.appspot.com/10697087/diff/1/chrome/browser/search_...
chrome/browser/search_engines/template_url_prepopulate_data.cc:3454: LOG(ERROR)
<< "Invalid country code: " << country_code;
On 2012/07/05 13:38:28, SteveT wrote:
> nit: Can we DVLOG instead? Or is this useful in release builds?

We don't need that in release builds indeed. I made it DLOG(ERROR).

[commit-bot: I haz the power, 2012-07-05 14:37:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pliard@chromium.org/10697087/6001

[commit-bot: I haz the power, 2012-07-05 15:57:49]

Change committed as 145539