Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 10697085: Fix compilation when disabling debugger support. (Closed)

Created:
8 years, 5 months ago by Yang
Modified:
8 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Fix compilation when disabling debugger support. Based on a patch by Remi Duraffort <remi.duraffort@st.com>;: http://codereview.chromium.org/10702093/ R=mstarzinger@chromium.org BUG= TEST=build with debuggersupport=off Committed: https://code.google.com/p/v8/source/detail?r=11995

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -30 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M samples/lineprocessor.cc View 10 chunks +14 lines, -22 lines 0 comments Download
M src/heap.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/liveedit.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime.cc View 3 chunks +7 lines, -1 line 0 comments Download
M test/cctest/test-heap-profiler.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
8 years, 5 months ago (2012-07-05 11:26:46 UTC) #1
Michael Starzinger
8 years, 5 months ago (2012-07-05 11:38:09 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698