Issue 10697082: aura: Scale custom cursors appropriately.

Issue 10697082: aura: Scale custom cursors appropriately. (Closed)

Created:
8 years, 5 months ago by sadrul

Modified:
8 years, 5 months ago

Reviewers:
brettw, Ben Goodger (Google)

CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aura: Scale custom cursors appropriately. BUG=135251 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145863

Patch Set 1 #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -1 line)			Patch
M	content/browser/renderer_host/render_widget_host_view_aura.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	webkit/glue/webcursor.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	webkit/glue/webcursor_aurawin.cc	View	1 chunk	+4 lines, -0 lines	2 comments	Download
M	webkit/glue/webcursor_aurax11.cc	View	3 chunks	+28 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

brettw

lgtm http://codereview.chromium.org/10697082/diff/1/webkit/glue/webcursor_aurawin.cc File webkit/glue/webcursor_aurawin.cc (right): http://codereview.chromium.org/10697082/diff/1/webkit/glue/webcursor_aurawin.cc#newcode17 webkit/glue/webcursor_aurawin.cc:17: // TODO(winguru): Usually you would write something after ...

8 years, 5 months ago (2012-07-10 05:07:19 UTC) #4

sadrul

8 years, 5 months ago (2012-07-10 11:39:35 UTC) #5

Thanks!

http://codereview.chromium.org/10697082/diff/1/webkit/glue/webcursor_aurawin.cc
File webkit/glue/webcursor_aurawin.cc (right):

http://codereview.chromium.org/10697082/diff/1/webkit/glue/webcursor_aurawin....
webkit/glue/webcursor_aurawin.cc:17: // TODO(winguru):
On 2012/07/10 05:07:19, brettw wrote:
> Usually you would write something after the todo. Even if it's just "implement
> cursors on aura." Many (most?) todos don't actually end up getting done, and
it
> can look quite strange to somebody else (or even yourself) in a while.

Fixed (this and the one above).

Expand Messages | Collapse Messages