Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: vm/object_test.cc

Issue 10697055: Represent tokens as a compressed stream instead of an array. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/object.cc ('k') | vm/parser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/object_test.cc
===================================================================
--- vm/object_test.cc (revision 9536)
+++ vm/object_test.cc (working copy)
@@ -142,10 +142,16 @@
EXPECT_EQ(6, ts.length());
EXPECT_EQ(Token::kLPAREN, ts[1].kind);
const TokenStream& token_stream = TokenStream::Handle(TokenStream::New(ts));
- EXPECT_EQ(6, token_stream.Length());
- EXPECT_EQ(Token::kLPAREN, token_stream.KindAt(1));
- EXPECT_EQ(Token::kPERIOD, token_stream.KindAt(4));
- EXPECT_EQ(Token::kEOS, token_stream.KindAt(5));
+ TokenStream::Iterator iterator(token_stream, 0);
+ // EXPECT_EQ(6, token_stream.Length());
+ iterator.Advance(); // Advance to '(' token.
+ EXPECT_EQ(Token::kLPAREN, iterator.CurrentTokenKind());
+ iterator.Advance();
+ iterator.Advance();
+ iterator.Advance(); // Advance to '.' token.
+ EXPECT_EQ(Token::kPERIOD, iterator.CurrentTokenKind());
+ iterator.Advance(); // Advance to end of stream.
+ EXPECT_EQ(Token::kEOS, iterator.CurrentTokenKind());
}
« no previous file with comments | « vm/object.cc ('k') | vm/parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698