Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 10697036: Enforce utf-8 codec on all files read and write. (Closed)

Created:
8 years, 5 months ago by M-A Ruel
Modified:
8 years, 5 months ago
Reviewers:
cmp
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, falken
Visibility:
Public.

Description

Enforce utf-8 codec on all files read and write. Otherwise, the files are opened in 'whatever happens to be the current encoding' which is highly system-dependent. Even if some files are not encoded with utf-8, the status quo is even worse. So it's worth trying out. TBR=cmp@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145306

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M gclient_utils.py View 2 chunks +4 lines, -11 lines 0 comments Download
M tests/gclient_utils_test.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
8 years, 5 months ago (2012-06-29 15:47:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10697036/1
8 years, 5 months ago (2012-07-03 16:05:30 UTC) #2
commit-bot: I haz the power
Change committed as 145306
8 years, 5 months ago (2012-07-03 16:08:16 UTC) #3
cmp
8 years, 5 months ago (2012-07-09 23:34:25 UTC) #4
lgtm (but if i recall correctly, this change ends up getting reverted later)

Powered by Google App Engine
This is Rietveld 408576698