Extend test for external arrays.

test/mjsunit/external-array.js

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 457 matching lines @@
 assertEquals(1, a[0]);
 assertEquals(3, a[2]);
 a = new Uint32Array(a);
 assertInstance(a, Uint32Array);
 assertEquals(3, a.length);
 assertEquals(12, a.byteLength);
 assertEquals(12, a.buffer.byteLength);
 assertEquals(4, a.BYTES_PER_ELEMENT);
 assertEquals(1, a[0]);
 assertEquals(3, a[2]);
-
+assertTrue(a.buffer instanceof ArrayBuffer);
+assertEquals(ArrayBuffer, a.buffer.constructor);

[rossberg, 2012/06/29 11:29:44]

You can use the assertInstance helper that is defined at the beginning of the
file (same below). Also, could you add the test to the other two cases above as
well?

[Yang, 2012/06/29 15:06:05]

Done.

 
 // Check subarrays.
 a = new Uint16Array([1,2,3,4,5,6]);
 aa = a.subarray(3);
 assertInstance(aa, Uint16Array);
 assertEquals(3, aa.length);
 assertEquals(6, aa.byteLength);
 assertEquals(2, aa.BYTES_PER_ELEMENT);
 assertSame(a.buffer, aa.buffer);
 aa = a.subarray(3,5);
@@ skipping 41 matching lines @@
 aa = a.subarray(0,-8);
 assertInstance(aa, Uint16Array);
 assertEquals(0, aa.length);
 assertEquals(0, aa.byteLength);
 assertEquals(2, aa.BYTES_PER_ELEMENT);
 assertSame(a.buffer, aa.buffer);
 
 assertThrows(function(){ a.subarray.call({}, 0) });
 assertThrows(function(){ a.subarray.call([], 0) });
 assertThrows(function(){ a.subarray.call(a) });
+
+var a = new Int32Array(10)
+var b = a.buffer
+print(b instanceof ArrayBuffer)
+print(b.constructor)

[rossberg, 2012/06/29 11:29:44]

This probably fits better with the tests following line 145.

[rossberg, 2012/06/29 14:14:50]

Please don't just delete this test, but have it integrated with the tests at
l.145 above. (It tests a different constructor call than the other tests you
inserted.)

[Yang, 2012/06/29 15:06:05]

Done.