Extend test for external arrays.

Extend test for external arrays.


R=rossberg@chromium.org
BUG=
TEST=

Committed: https://code.google.com/p/v8/source/detail?r=11953

[rossberg, 2012-06-29 11:29:44]

Thanks!

LGTM, with some nits.

https://chromiumcodereview.appspot.com/10697033/diff/1/test/mjsunit/external-...
File test/mjsunit/external-array.js (right):

https://chromiumcodereview.appspot.com/10697033/diff/1/test/mjsunit/external-...
test/mjsunit/external-array.js:479: assertEquals(ArrayBuffer,
a.buffer.constructor);
You can use the assertInstance helper that is defined at the beginning of the
file (same below). Also, could you add the test to the other two cases above as
well?

https://chromiumcodereview.appspot.com/10697033/diff/1/test/mjsunit/external-...
test/mjsunit/external-array.js:545: print(b.constructor)
This probably fits better with the tests following line 145.

[Yang, 2012-06-29 13:05:24]

Please take another look.

[rossberg, 2012-06-29 14:14:50]

LGTM, with another comment.

https://chromiumcodereview.appspot.com/10697033/diff/1/test/mjsunit/external-...
File test/mjsunit/external-array.js (right):

https://chromiumcodereview.appspot.com/10697033/diff/1/test/mjsunit/external-...
test/mjsunit/external-array.js:545: print(b.constructor)
On 2012/06/29 11:29:44, rossberg wrote:
> This probably fits better with the tests following line 145.

Please don't just delete this test, but have it integrated with the tests at
l.145 above. (It tests a different constructor call than the other tests you
inserted.)

[Yang, 2012-06-29 15:06:05]

https://chromiumcodereview.appspot.com/10697033/diff/1/test/mjsunit/external-...
File test/mjsunit/external-array.js (right):

https://chromiumcodereview.appspot.com/10697033/diff/1/test/mjsunit/external-...
test/mjsunit/external-array.js:479: assertEquals(ArrayBuffer,
a.buffer.constructor);
On 2012/06/29 11:29:44, rossberg wrote:
> You can use the assertInstance helper that is defined at the beginning of the
> file (same below). Also, could you add the test to the other two cases above
as
> well?

Done.

https://chromiumcodereview.appspot.com/10697033/diff/1/test/mjsunit/external-...
test/mjsunit/external-array.js:545: print(b.constructor)
On 2012/06/29 14:14:50, rossberg wrote:
> On 2012/06/29 11:29:44, rossberg wrote:
> > This probably fits better with the tests following line 145.
> 
> Please don't just delete this test, but have it integrated with the tests at
> l.145 above. (It tests a different constructor call than the other tests you
> inserted.)

Done.